More complete hash for JetDefinition

@delsart, it seemed weird to me that we were not hashing & comparing equality with the algorithm parameter, and also VR jet parameters were not compared. Then I realised that basename neatly captures the full description of the jet clustering configuration, and as it's governed by the lproperties logic, it remains complete. It should only be the naming parameters like prefix, infix, suffix that can be ignored in the hash. I added the byVertex option as well, as it seems relevant.

Do you think I missed anything?

Added __repr__ = __str__ for a couple of the classes that were missing it as well, as I was seeing the pointer addresses show up in some printouts.

This merge request affects 1 package:

• Reconstruction/Jet/JetRecConfig

This merge request affects 1 file:

• Reconstruction/Jet/JetRecConfig/python/JetDefinition.py

Adding @miochoa ,@cantel ,@goetz as watchers

added 24.0 JetEtmiss Reconstruction review-pending-level-1 labels

CI Result SUCCESS (hash 84c31391)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8633] (remote access info)

The changes are straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

Hi TJ, Thanks again for this MR. I don't see anything more to add. Cheers, P-A

added review-approved-tier0 label

mentioned in commit 4384878d

merged

mentioned in merge request !70922 (merged)