Add unit test for the text configuration

A unit test that compares the configuration sequence produced by the text configuration and that of the block configuration is added. May not be useful since ntuples are produced using the text and block configuration and compared as part of the integration tests.

Changes:

• add returnConfigSeq option to makeSequenceBlocks that returns the config sequence object.
• add unit test to compare config sequence produced with the text and block configurations
• some code was rearranged so that the order of the blocks align between the text and block configurations.
• added some blocks and options that were not preset in the text configuration

Note: the order in the block configuration will need to match the order in determined by the ConfigFactory or the code will fail the integration tests.

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @krumnack ,@tadej as watchers

added Analysis CPAlgorithms analysis-review-required main review-pending-level-1 labels

changed the description

I'm not sure we want that. What we had before was not that slow. Can we first add just a unit test but not disable the old tests?

This one is for @krumnack , setting appropriate label

Giovanni (AR)

removed analysis-review-required label

added analysis-review-expert label

added 1 commit

• 9c5ecdfe - add integration tests back in

Compare with previous version

changed title from Replace text config integration tests to Add unit test for the text configuration

changed the description

CI Result SUCCESS (hash a665ed86)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8634] (remote access info)

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @tadej ,@krumnack as watchers

CI Result SUCCESS (hash 9c5ecdfe)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8649] (remote access info)

added analysis-review-approved label and removed analysis-review-expert label

This is a planned update to the CP algorithms, only adding a unit test. Approving for AR.

Cheers, Nils [Analysis RC]

Changes look ok to me, but please resolve the discussion thread before we can approve.
Albert (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 350 commits

• 9c5ecdfe...68e8b97a - 348 commits from branch atlas:main
• e5561290 - replace text config integration tests
• f3407bb1 - add integration tests back in

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @tadej ,@krumnack as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• c512b942 - fix type in unit test script

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @tadej ,@krumnack as watchers

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash f3407bb1)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8936] (remote access info)

CI Result FAILURE (hash c512b942)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8937] (remote access info)

added 2 commits

• bf11e0af - fix config unit test compare with blocks
• 80355f05 - add algs to builder and move blocks to match yaml

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @tadej ,@krumnack as watchers

added 1 commit

• 96ec621c - update FullCPAlgorithmsTest so that the order matches the text config and is...

Compare with previous version

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/CMakeLists.txt
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText_unitTest.py
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py

Adding @krumnack ,@tadej as watchers

CI Result SUCCESS (hash 80355f05)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8943] (remote access info)

CI Result SUCCESS (hash 96ec621c)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8948] (remote access info)

Hi @jolamber. Can the thread be resolved?

-- James for L1

resolved all threads

Looks good, approving - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit e1865bb0