TruthSvc: fix warning about unused variable (ATLASSIM-7180)

Fix unused variable warning which appeared as a result of the clean-up in !70887 (merged).

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Services

This merge request affects 2 files:

• Simulation/ISF/ISF_Core/ISF_Services/src/TruthSvc.cxx
• Simulation/ISF/ISF_Core/ISF_Services/test/TruthSvc_test.cxx

Adding @jchapman ,@lmijovic as watchers

added Simulation main review-pending-level-1 labels

CI Result SUCCESS (hash e235918d)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8669] (remote access info)

Do not know the impact of removing one ::testing::Return(inParticle3). Pass to L2 for review.

-- Mingxu (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

The unit test calls TruthSvc methods using a MockTruthIncident where I can control what the member functions return each time they are called.
In TruthSvc.cxx I've removed one call to TruthIncident::parentParticle(). Therefore the unit test has to be updated to expect fewer calls to this function and as such fewer return values have to be specified.

resolved all threads

added review-approved label and removed review-pending-level-2 label

The functional change is well explained by the author. No need for L2 review. Approved from L1.

merged

mentioned in commit 036437d0