Edge case fixes for jFEX Sim

This MR fixes various edge cases in the jFEX simulation:

• fixed integer overflows in jXE calculation
• fixed jEM seed condition eliminating both seed candidates in case of equal ET instead of choosing one over the other (wrong comparison operator was used in direction requiring a candidate to have greater or equal energy than a neighboring seed)
• added LAr saturation bit propagation in jFEX fwdEM algorithm (purely to improve fw/sim comparison for monitoring; the resulting jEM saturation bit is in practice ignored by L1Topo)

added 1 commit

• ed9aa694 - adding saturation bit handling to jFEX forwardEM

Compare with previous version

changed the description

marked this merge request as ready

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 7 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jFEXForwardElecAlgo.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jFEXForwardElecInfo.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/jFEXmetAlgo.h
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXFormTOBs.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXForwardElecAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXForwardElecInfo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/jFEXmetAlgo.cxx

Adding @will ,@thompson as watchers

added 24.0 L1Calo Trigger review-pending-level-1 labels

CI Result SUCCESS (hash ed9aa694)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8810] (remote access info)

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

mentioned in commit 47cc333f

merged

mentioned in merge request !71094 (merged)