Fixing bug in reading ITkPRDToTrackMap and saving SiSPSeededTracks for other ITk extensions

When trying to save the SiSPSeededTrack collection in the actsValidateTracks tracking pass, a few bugs on the configuration of the tool have been found.

FYI: @tstreble @cvarni @goetz @adye @astefl

The command I have used is the following:

Reco_tf.py --CA \
--steering doRAWtoALL \
--preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude,ActsConfig.ActsCIFlags.actsValidateTracksFlags" \
--preExec "ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.doTruth=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True; ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True; ConfigFlags.Debug.DumpEvtStore=False" \
--inputRDOFile $RDO \
--outputAODFile $AOD \
--maxEvents $NumberOfEvents

This allows to store SiSPSeededTracksActsValidateTracksTrackParticles (ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True) as well as truth information on ITk pixel and strip clusters (ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True).

Once these information is available in the AOD, you can easily produce technical efficiency plots and investigate the aforementioned track collection:

runIDPVM.py --filesInput $AOD --outputFile $IDPVM \
--validateExtraTrackCollections 'SiSPSeededTracksActsValidateTracksTrackParticles' --doTechnicalEfficiency --doExpertPlots

assigned to @ncalace

This merge request affects 2 packages:

• InnerDetector/InDetConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet

Affected files list will not be printed in this case

Adding @jcatmore ,@dshope ,@emmat ,@jburzyns ,@tstreble ,@goetz ,@sroe as watchers

added Derivation ITk InnerDetector main review-pending-level-1 labels

thanks for fixing this @ncalace . Can you update https://gitlab.cern.ch/atlas/athena/-/blob/main/Tracking/Acts/ActsConfig/test/ActsPersistifySeeds.sh setting the proper flags there too?

added 1 commit

• 5ef688ca - resolving

Compare with previous version

resolved all threads

added Tracking label

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Tracking/Acts/ActsTruth
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @jburzyns ,@pagessin ,@jojungge ,@cvarni ,@tbold ,@dshope ,@sroe ,@toyamaza ,@emmat ,@goetz ,@jcatmore ,@tstreble as watchers

added ACTS label

CI Result SUCCESS (hash 0f4bf43b)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8776] (remote access info)

CI Result FAILURE (hash 5ef688ca)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8782] (remote access info)

Hi @ncalace. There are some errors and warnings here, such as this one:

AWtoALL 16:28:25 PrecedenceSvc                                                0   ERROR   Strongly connected components found in DF realm:
RAWtoALL 16:28:25  o [lowlink:39] | ITkAmbiguityScoreConversion | ITkSiSpTrackFinderROIConvConversion |
RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize service "PrecedenceSvc"
RAWtoALL 16:28:25 AvalancheSchedulerSvc                                        0   FATAL Error retrieving PrecedenceSvc
RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize service "AvalancheSchedulerSvc"
RAWtoALL 16:28:25 AthenaHiveEventLoopMgr                                       0   FATAL Error retrieving SchedulerSvc interface ISchedulerSvc.
RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize Service: AthenaHiveEventLoopMgr
RAWtoALL 16:28:25 Py:ComponentAccumulator   ERROR Failed to initialize AppMgr

Can these be looked into?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

@ncalace can you rebase on top of !71002 (merged) ? I've clarified the configs of the PRDtoTrackMap there.

This has now taken merge conflicts (as expected). @ncalace can you address these?

added 155 commits

• 5ef688ca...a2f5545c - 153 commits from branch atlas:main
• 9df85954 - fixing bug in reading ITkPRDToTrackMap and saving SiSPSeededTracks for other ITk extensions
• 855eb5e1 - resolving

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Tracking/Acts/ActsTruth
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @jburzyns ,@tstreble ,@goetz ,@sroe ,@jojungge ,@pagessin ,@cvarni ,@toyamaza ,@jcatmore ,@emmat ,@dshope ,@tbold as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

You missed a few conflicts ;)

Sorry...

added 1 commit

• 2e1fd5af - resolving conflicts

Compare with previous version

resolved all threads

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Tracking/Acts/ActsTruth
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @jcatmore ,@jburzyns ,@toyamaza ,@tbold ,@pagessin ,@sroe ,@goetz ,@dshope ,@cvarni ,@jojungge ,@emmat ,@tstreble as watchers

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 855eb5e1)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8942] (remote access info)

CI Result SUCCESS (hash 2e1fd5af)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8947] (remote access info)

The changes look okay and now there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit e5046170