Fixing bug in reading ITkPRDToTrackMap and saving SiSPSeededTracks for other ITk extensions

When trying to save the SiSPSeededTrack collection in the actsValidateTracks tracking pass, a few bugs on the configuration of the tool have been found.

FYI: @tstreble @cvarni @goetz @adye @astefl

The command I have used is the following:

Reco_tf.py --CA \
--steering doRAWtoALL \
--preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude,ActsConfig.ActsCIFlags.actsValidateTracksFlags" \
--preExec "ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.doTruth=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True; ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True; ConfigFlags.Debug.DumpEvtStore=False" \
--inputRDOFile $RDO \
--outputAODFile $AOD \
--maxEvents $NumberOfEvents

This allows to store SiSPSeededTracksActsValidateTracksTrackParticles (ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True) as well as truth information on ITk pixel and strip clusters (ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True).

Once these information is available in the AOD, you can easily produce technical efficiency plots and investigate the aforementioned track collection:

runIDPVM.py --filesInput $AOD --outputFile $IDPVM \
--validateExtraTrackCollections 'SiSPSeededTracksActsValidateTracksTrackParticles' --doTechnicalEfficiency --doExpertPlots

InnerDetector/InDetConfig/python/ITkTrackRecoConfig.py

@@ -448,14 +448,25 @@ def ITkExtendedPRDInfoCfg(flags):
     result.merge(ITkTSOS_CommonKernelCfg(flags))
 
     if flags.Tracking.doStoreSiSPSeededTracks:
+        listOfExtensionsRequesting = [
+            e for e in _extensions_list if (e=='') or
+            flags.Tracking.__getattr__(f"ITk{e}Pass").storeSiSPSeededTracks ]
         from DerivationFrameworkInDet.InDetToolsConfig import (
             ITkSiSPTSOS_CommonKernelCfg)
-        result.merge(ITkSiSPTSOS_CommonKernelCfg(flags))
+        result.merge(ITkSiSPTSOS_CommonKernelCfg(flags, listOfExtensions = listOfExtensionsRequesting))
 
     if flags.Input.isMC:
+        listOfExtensionsRequesting = [
+            e for e in _extensions_list if (e=='') or
+            (flags.Tracking.__getattr__(f"ITk{e}Pass").storeSiSPSeededTracks and
+             flags.Tracking.__getattr__(f"ITk{e}Pass").storeSeparateContainer) ]
         from InDetPhysValMonitoring.InDetPhysValDecorationConfig import (
             ITkPhysHitDecoratorAlgCfg)
-        result.merge(ITkPhysHitDecoratorAlgCfg(flags))
+        for extension in listOfExtensionsRequesting:
+            result.merge(ITkPhysHitDecoratorAlgCfg(
+                flags,
+                name=f"ITkPhysHit{extension}DecoratorAlg",
+                TrackParticleContainerName=f"ITk{extension}TrackParticles"))
 
     return result