Skip to content
Snippets Groups Projects

Rewrite Acts seeding cfg function

Merged Carlo Varni requested to merge cvarni/athena:RewriteSeedingJobOption into main
All threads resolved!

This rewrites the cfg function so that we can impose a consistent naming convention for our algorithms and I/O

It relies on selecting specific subsets of parameters from the kwargs. These parameters are properly set in the cfg function and passed to the main cfg function

Merge request reports

Pipeline #7312077 passed

Pipeline passed for 24db4718 on cvarni:RewriteSeedingJobOption

Approval is optional

Merged by Walter LamplWalter Lampl 10 months ago (Apr 30, 2024 5:00pm UTC)

Merge details

  • Changes merged into main with fef21c42 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Tracking/Acts/ActsConfig

    This merge request affects 3 files:

    • Tracking/Acts/ActsConfig/python/ActsSeedingConfig.py
    • Tracking/Acts/ActsConfig/python/ActsTruthConfig.py
    • Tracking/Acts/ActsConfig/python/ActsUtilities.py

    Adding @jojungge ,@toyamaza ,@pagessin ,@tbold ,@cvarni as watchers

  • :x: CI Result FAILURE (hash 5fcefeca)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8830] (remote access info)

  • Carlo Varni resolved all threads

    resolved all threads

  • :x: CI Result FAILURE (hash 13530bf2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8831] (remote access info)

  • Hi @cvarni. A few errors here, such as

    RAWtoALL 14:11:29 ActsValidateTracksPixelSeedingAlg                      0     0   ERROR ActsPatternRecognition/src/SeedingAlg.cxx:116 (StatusCode ActsTrk::SeedingAlg::execute(const EventContext&) const): code FAILURE: handle.isValid()
    RAWtoALL 14:11:29 ActsValidateTracksPixelSeedingAlg                      0     0   ERROR Maximum number of errors ( 'ErrorMax':1) reached.
    RAWtoALL 14:11:29 AlgTask                                                0     0 WARNING Execution of algorithm ActsValidateTracksPixelSeedingAlg failed

    -- James for L1

  • Carlo Varni added 1 commit

    added 1 commit

    • 24db4718 - Partial naming convention - to be fixed in follow ups

    Compare with previous version

  • This merge request affects 1 package:

    • Tracking/Acts/ActsConfig

    This merge request affects 4 files:

    • Tracking/Acts/ActsConfig/python/ActsSeedingConfig.py
    • Tracking/Acts/ActsConfig/python/ActsTrackFindingConfig.py
    • Tracking/Acts/ActsConfig/python/ActsTruthConfig.py
    • Tracking/Acts/ActsConfig/python/ActsUtilities.py

    Adding @adye ,@toyamaza ,@cvarni ,@pagessin ,@tbold ,@jojungge as watchers

  • :white_check_mark: CI Result SUCCESS (hash 24db4718)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8840] (remote access info)

  • The changes look okay and there are no issues with the CI. Approving from L1.

  • Walter Lampl mentioned in commit fef21c42

    mentioned in commit fef21c42

  • Please register or sign in to reply
    Loading