Fix issues when running multiple overlap removal configurations in CP algorithms

Currently, if a user tries to run multiple overlap removal blocks with different configuration, neither selectionName nor postfix is propagated to the output variables that specify the selection. This MR fixes this bug and also cleans up the interface a bit:

• postfix option is removed as it is confusing having both this and selectionName
• internally, all decorations and output variables are appended a postfix based on the selectionName

Importantly, for people using single OR configuration with default settings (i.e. not setting selectionName/postfix manually), nothing changes.

added 1 commit

• af977b96 - Fix individual OR output decorations for multiple instances.

Compare with previous version

added 1 commit

• 2faeb863 - Fix individual OR input/output decorations for multiple instances.

Compare with previous version

added 1 commit

• 711599d1 - Use selectionName and remove postfix as config option

Compare with previous version

changed the description

marked this merge request as ready

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms

This merge request affects 1 file:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/python/OverlapAnalysisConfig.py

Adding @krumnack ,@tadej as watchers

added Analysis CPAlgorithms analysis-review-required main review-pending-level-1 labels

added analysis-interface-change label

I'm adding the analysis-interface-change label, since strictly speaking this does break interface, however probably 99.9% of users will not notice and the people needing multiple OR setups anyway need to adjust things, since currently multiple ORs are broken...

CI Result SUCCESS (hash 711599d1)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8914] (remote access info)

Asking expert to have a look @krumnack from analysis release side.

removed analysis-review-required label

added analysis-review-expert label

The changes are straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

This was discussed beforehand and is otherwise fine. Approving for AR.

The change to the analysis interfaces is so minor, that it's probably borderline whether we should even mark it. If I understood things correctly there is no way anybody could make meaningful use of the postfix option as is. So removing that option ought to be fine.

Regards, Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-expert label

mentioned in commit 2cc82e56

merged