Simplification for truth record functions

Simplification for truth record functions

assigned to @averbyts

marked this merge request as draft

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

added Analysis BTagging JetEtmiss analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 56863435)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8889] (remote access info)

removed review-pending-level-1 label

marked this merge request as ready

added 210 commits

• 56863435...fad05a10 - 209 commits from branch atlas:main
• 09e9f392 - Merge branch 'main' into 'ftd01052024'

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

added review-pending-level-1 label

CI integration tests for projects Athena,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 09e9f392)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9068] (remote access info)

Simplification for truth record functions, no changes in analysis model, so approving from analysis side. Tong (AR)

removed analysis-review-required label

added analysis-review-approved label

Switching tags while CI failure

--Qiyu, L1

removed review-pending-level-1 label

added review-user-action-required label

added 92 commits

• 09e9f392...d17085f2 - 91 commits from branch atlas:main
• 7cdcc21d - Merge branch athena:main into ftd01052024

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• c2437d78 - Update TruthDecoratorHelpers.cxx

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

CI integration tests for projects Athena,AthAnalysis are cancelled because of compilation error(s)

CI integration tests for projects Athena,AnalysisBase are cancelled because of compilation error(s)

CI Result FAILURE (hash 7cdcc21d)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9176] (remote access info)

CI Result FAILURE (hash c2437d78)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9177] (remote access info)

Switching tags while CI failure

--Qiyu, L1

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• 92ad6571 - Update TruthDecoratorHelpers.cxx

Compare with previous version

added 232 commits

• 92ad6571...8e89f61c - 231 commits from branch atlas:main
• 1e01716d - Merge branch athena:main into ftd01052024

Compare with previous version

removed review-user-action-required label

added review-pending-level-1 label

Build area was cleaned as per request posted in the DB. The full software build will be performed

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 2 files:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthDecoratorHelpers.cxx
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/TruthParticleDecoratorAlg.cxx

CI Result SUCCESS (hash 92ad6571)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9413] (remote access info)

CI Result SUCCESS (hash 1e01716d)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9414] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving

Cheers, Qiyu, L1

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 3141066f