RpcSensitivieDetectors - Remove never implemented rotation logic

In real ATLAS, half of the chambers were built-in upside down. The GeoModel does not have this flexibility though it's been claimed in the variable names of the sensitive detectors. Yes, that's an intrinsic bias in rpc digitization but I'm pretty convinced that it would just inspire

even more, if he were alive today. On the other hand, the digi is anyhow broken in main.

Anyhow, I'm not expecting any change in the simulation output but let me tag @mbandier, @jchapman, @tlari such that they can press the revert button, if I'm surprisingly wrong and the ART tests trigger.

Tagging: @pscholer, @goblirsc, @minions, @atlasbot

MuonSpectrometer/MuonG4/MuonG4SD/src/RPCSensitiveDetector.cxx

@@ -50,8 +50,6 @@ G4bool RPCSensitiveDetector::ProcessHits(G4Step* aStep,G4TouchableHistory*) {
   const G4AffineTransform trans     = track->GetTouchable()->GetHistory()->GetTopTransform(); // from global to local
 
   // necessary to assign correct identifiers
-  int rpcIsRotated      = 0;
-  // int layer             = 0;
 
   std::string tech;
   // fields for the RPC identifier construction
@@ -158,7 +156,6 @@ G4bool RPCSensitiveDetector::ProcessHits(G4Step* aStep,G4TouchableHistory*) {
       }
       int kk=gmID;
 
-      if (kk < 0) rpcIsRotated=1;
 
       doubletR =(abs(kk)%1000)/100;
       mydbZ    = abs(int(kk%10));
@@ -180,21 +177,15 @@ G4bool RPCSensitiveDetector::ProcessHits(G4Step* aStep,G4TouchableHistory*) {
 
       int kk=touchHist->GetVolume(i)->GetCopyNo();
 
-      if (kk < 0) rpcIsRotated=1;
+
 
       doubletR=(abs(kk)%1000)/100;
 
     } else if ((npos = volName.find("layer")) != std::string::npos) {
 
       int copyNo = touchHist->GetVolume(i)->GetCopyNo();
+      gasGap = copyNo;
 
-      if (copyNo == 1) {
-        rpcIsRotated ? gasGap = 2 : gasGap = 1;
-      } else if (copyNo ==2) {
-        rpcIsRotated ? gasGap = 1 : gasGap = 2;
-      } else if (copyNo ==3) {
-        gasGap = 3;
-      }
     } else if((npos = volName.find("gas volume")) != std::string::npos) {
 
       int copyNo = touchHist->GetVolume(i)->GetCopyNo();