Skip to content
Snippets Groups Projects

FTAG GNN inference cleanup

Merged FTAG GNN inference cleanup
svanstro/athena:svanstro/cleanup-ftag-inference-bits into 24.0
Merged Samuel Van Stroud requested to merge svanstro/athena:svanstro/cleanup-ftag-inference-bits into 24.0
  • Improve function and type naming (e.g. "getters" "custom getters" etc)
  • Improve type aliasing
  • Start work on the V2 onnx metadata version. More to follow, see https://its.cern.ch/jira/browse/AFT-730
Edited by Samuel Van Stroud

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Guest
    Dan Guest @dguest ·
    Developer

    Personally I'm a big fan of this kind of cleanup, and it won't interfere with the stuff I'm doing in !70787 (merged).

    Stretch goal for this MR: replace xAOD::Jet with xAOD::IParticle wherever you can. I don't think we need anything specific to xAOD::Jet and if we move to the base class we could also talk about using this for tau id.

  • Samuel Van Stroud added 61 commits

    added 61 commits

    Compare with previous version

  • Samuel Van Stroud
    Samuel Van Stroud @svanstro ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 12 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/ConstituentsLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/CustomGetterUtils.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/IParticlesLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/TracksLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/ConstituentsLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/CustomGetterUtils.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/IParticlesLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/TracksLoader.cxx
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash d3ead198)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :o:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 4
    :o: AnalysisBase: number of compilation errors 1, warnings 5
    :o: AthAnalysis: number of compilation errors 1, warnings 2
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9232] (remote access info)

  • Samuel Van Stroud added 1 commit

    added 1 commit

    Compare with previous version

  • Samuel Van Stroud
    Samuel Van Stroud @svanstro ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 12 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/ConstituentsLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/CustomGetterUtils.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/IParticlesLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/TracksLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/ConstituentsLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/CustomGetterUtils.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/IParticlesLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/TracksLoader.cxx
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash b49d7439)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9239] (remote access info)

  • Dan Guest mentioned in merge request !71323 (merged)

    mentioned in merge request !71323 (merged)

  • Samuel Van Stroud changed the description

    changed the description

  • Samuel Van Stroud resolved all threads

    resolved all threads

  • Samuel Van Stroud marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 12 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/ConstituentsLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/CustomGetterUtils.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/IParticlesLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/TracksLoader.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/ConstituentsLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/CustomGetterUtils.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/IParticlesLoader.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/TracksLoader.cxx
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply