ITk pixel bytestream encoding

Inital setup which implements RDO access with retrieval of pixel geometry and ToT. Project is still a work in progress.

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv

This merge request affects 6 files:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelByteStreamCnvConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/run/JO.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ATLAS_CHECK_THREAD_SAFETY
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.h
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/components/ITkPixelByteStreamCnv_entries.cxx

Adding @stsuno ,@battagl ,@goetz ,@sroe ,@lshan as watchers

added ITk InnerDetector main review-pending-level-1 labels

CI Result FAILURE (hash 9a13e308)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8995] (remote access info)

The CI test failed ERROR Cannot create tool ITkPixelRawDataProviderTool (No factory found). Move back to user for action.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 3ab9403e - fix pipeline

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv

This merge request affects 8 files:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/CMakeLists.txt
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelByteStreamCnvConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelEncodingAlgConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/run/JO.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ATLAS_CHECK_THREAD_SAFETY
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.h
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/components/ITkPixelByteStreamCnv_entries.cxx

Adding @goetz ,@lshan ,@sroe ,@stsuno ,@battagl as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 3ab9403e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9022] (remote access info)

Some small comments. Others look fine to me.

added review-user-action-required label and removed review-pending-level-1 label

ref.: ATLITKSW-232

added 1 commit

• 49facf96 - minor syntax changes

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv

This merge request affects 8 files:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/CMakeLists.txt
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelByteStreamCnvConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelEncodingAlgConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/run/JO.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ATLAS_CHECK_THREAD_SAFETY
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.h
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/components/ITkPixelByteStreamCnv_entries.cxx

Adding @lshan ,@battagl ,@goetz ,@sroe ,@stsuno as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 49facf96)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9128] (remote access info)

Warning detected on unused variables:

  117 |         int chip = std::ceil(pixEtaIx/columnsPerChip) + chipsInPhi*std::ceil(pixPhiIx/rowsPerChip);
      |             ^~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx:67:15: warning: unused variable 'chipsinEta' [-Wunused-variable]
   67 |     const int chipsinEta = design->columns()/columnsPerChip;
      |               ^~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx:70:10: warning: variable 'use50x50' set but not used [-Wunused-but-set-variable]
   70 |     bool use50x50 = true;```

Please fix them.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 8f5c5159 - removing compiler warnings

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv

This merge request affects 8 files:

• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/CMakeLists.txt
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelByteStreamCnvConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/python/ITkPixelEncodingAlgConfig.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/run/JO.py
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ATLAS_CHECK_THREAD_SAFETY
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.cxx
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/ITkPixelEncodingAlg.h
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv/src/components/ITkPixelByteStreamCnv_entries.cxx

Adding @sroe ,@stsuno ,@battagl ,@lshan ,@goetz as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 8f5c5159)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9221] (remote access info)

resolved all threads

MR looks fine from L1 perspective, CI shows no problems - approving

Cheers, Qiyu, L1

removed review-pending-level-1 label

added review-approved label

There are still a number of commented out code lines, but I since I read that this is work-in-progress I will merge this MR now and hope you will clean this up in a future MR.

merged

mentioned in commit 72157f68