expose skipSystematicJetSelection option in MetAnalysisConfig, rename associated property in MetMaker tool

This should make it easier for more users to run their own tests with this simplified OR scheme. It is not meant for actual physics analysis, but strictly to simplify such performance studies.

The rename is to make it clearer what the option/property actually does.

cc @bhodkins @khoo @ekourlit @gwatts

Hello. I'm not at all opposed to making it easier for more people to test this out, but as per my repeated comment on related presentations: Given the current implementation, this option does not permit anybody to alter how the OR is done, only threshold effects on jet systematics. So as it stands, the name is misleading, and I would not like that the collaboration as a whole draws conclusions that we are testing more than we actually are at this time.

I think something like skipSystematicJetSelection would be more a accurate description of what is currently possible, and if the logic were extended in future, the options could similarly be renamed. That would also indicate that METMaker should have a more precisely named property toggling this.

added 1 commit

• 9e735dae - do some renames as requested in MR

Compare with previous version

This changes the interface, as it renames a property, but the property is experimental and shouldn't have a lot of users. Still adding analysis-interface-change.

resolved all threads

added analysis-interface-change label

changed title from expose doSimpleOR option in MetAnalysisConfig to expose skipSystematicJetSelection option in MetAnalysisConfig, rename associated property in MetMaker tool

changed the description

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/MetAnalysisAlgorithms
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz ,@krumnack ,@tadej as watchers

added Analysis CPAlgorithms JetEtmiss Reconstruction analysis-review-required main review-pending-level-1 labels

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/MetAnalysisAlgorithms
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @tadej ,@goetz ,@krumnack as watchers

CI Result SUCCESS (hash d7071f22)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9037] (remote access info)

CI Result SUCCESS (hash 9e735dae)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9041] (remote access info)

This looks no impact on actual physics analysis, so approving from analysis release side. Tong (AR)

removed analysis-review-required label

added analysis-review-approved label

Switching tags while under discussion

--Qiyu, L1

removed review-pending-level-1 label

added review-user-action-required label

resolved all threads

added review-pending-level-1 label and removed review-user-action-required label

All discussions resolved, resetting review label.

MR looks fine from L1 perspective, CI shows no problems - approving

Cheers, Qiyu, L1

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 49b82870