Skip to content
Snippets Groups Projects

Use C++20 Spans in BLS Vertexing code

Merged Adam Edward Barton requested to merge abarton/athena:spanv0tools into main
All threads resolved!

std::span in C++20 allows an interface to take any contiguous container (std::vector or std::array) this allows greater flexibility in design allowing fewer allocations.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Switching tags while under discussion

    --Qiyu, L1

  • added 1 commit

    Compare with previous version

  • Adam Edward Barton resolved all threads

    resolved all threads

  • Adam Edward Barton marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 6 packages:

    • Event/xAOD/xAODBPhys
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
    • PhysicsAnalysis/JpsiUpsilonTools
    • Tracking/TrkVertexFitter/TrkVKalVrtFitter
    • Tracking/TrkVertexFitter/TrkVertexAnalysisUtils
    • Trigger/TrigMonitoring/TrigBphysMonitoring

    Affected files list will not be printed in this case

    Adding @emmat ,@tursom ,@wwalko ,@akraszna ,@abarton ,@bouhova ,@jcatmore as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 108K in file Tracking/TrkVertexFitter/TrkVertexAnalysisUtils/src/V0Tools.cxx

  • :white_check_mark: CI Result SUCCESS (hash 09287120)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9120] (remote access info)

  • Mingxu He
  • Only one comment on the indentations. Others looks good to me.

    --Mingxu (L1)

  • Developer

    Looks no impact on analysis, approving from analysis side. Tong (AR)

  • added 1 commit

    Compare with previous version

  • Adam Edward Barton resolved all threads

    resolved all threads

  • This merge request affects 6 packages:

    • Event/xAOD/xAODBPhys
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
    • PhysicsAnalysis/JpsiUpsilonTools
    • Tracking/TrkVertexFitter/TrkVKalVrtFitter
    • Tracking/TrkVertexFitter/TrkVertexAnalysisUtils
    • Trigger/TrigMonitoring/TrigBphysMonitoring

    Affected files list will not be printed in this case

    Adding @bouhova ,@jcatmore ,@wwalko ,@tursom ,@akraszna ,@abarton ,@emmat as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 108K in file Tracking/TrkVertexFitter/TrkVertexAnalysisUtils/src/V0Tools.cxx

  • :white_check_mark: CI Result SUCCESS (hash a0526a2b)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9144] (remote access info)

  • MR looks fine from L1 perspective, CI shows no problems - approving

    Cheers, Qiyu, L1

  • mentioned in commit 7755be4c

  • Please register or sign in to reply
    Loading