Remove configurable flag m_doUnderOverflowChecks and always assume it is true

Remove configurable flag m_doUnderOverflowChecks and always assume it is true

@jchapman @pclark

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Simulation/Barcode/BarcodeServices

This merge request affects 8 files:

• Simulation/Barcode/BarcodeServices/BarcodeServices/GenericBarcodeSvc.h
• Simulation/Barcode/BarcodeServices/BarcodeServices/GlobalBarcodeSvc.h
• Simulation/Barcode/BarcodeServices/BarcodeServices/LegacyBarcodeSvc.h
• Simulation/Barcode/BarcodeServices/BarcodeServices/ValidationBarcodeSvc.h
• Simulation/Barcode/BarcodeServices/src/GenericBarcodeSvc.cxx
• Simulation/Barcode/BarcodeServices/src/GlobalBarcodeSvc.cxx
• Simulation/Barcode/BarcodeServices/src/LegacyBarcodeSvc.cxx
• Simulation/Barcode/BarcodeServices/src/ValidationBarcodeSvc.cxx

Adding @jchapman as watcher

added Simulation main review-pending-level-1 labels

CI Result SUCCESS (hash c3ca8f23)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9105] (remote access info)

Approved from L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 6345d7b8