sTgcReadoutGeometry - Minor clean-up of the factory methods & msg streams

• Use ATH_MSG macros instead of instantiating the msgStream manually
• Split the initDesign method to the AGDD part & the sqlite part. That's just for improving the readability.
• Use stringUtil functions to extract the constants

Prerequisite to translate the R4-style geometry to the legacy style geometry.

added full-unit-tests label

This merge request affects 3 packages:

• MuonSpectrometer/MuonDetDescr/MuonDetDescrUtils
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @pscholer ,@jojungge ,@apsallid ,@stavrop ,@rosati ,@kluit as watchers

added MuonSpectrometer main review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 3faba1cb)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9169] (remote access info)

Switching tags while CI failure --Qiyu, L1

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• 9a26864e - Fix compiler

Compare with previous version

This merge request affects 4 packages:

• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonDetDescr/MuonDetDescrUtils
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @pscholer ,@stavrop ,@rosati ,@gemmeren ,@apsallid ,@kluit ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 9a26864e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9174] (remote access info)

Changes look fine from L1 but are extensive, turn to L2 for comments

--Qiyu, L1

removed review-pending-level-1 label

added review-pending-level-2 label

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit bd30992f