Update BPHY13 and BPHY23
we want to use the release 25.0.4 to test the derivation by using MC20 and MC23, respectively, so we update the BPHY13.py and BPHY23.py, and run successfully
This fixes an important missing line acc.addPublicTool(BPHY23_SelectEvent)
and makes other minor changes related to vertexing parameters.
Merge request reports
Activity
added Derivation main labels
assigned to @shpeng
This merge request affects 1 package:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
This merge request affects 2 files:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY13.py
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY23.py
added review-pending-level-1 label
CI Result SUCCESS (hash e3aa3a49)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9202] (remote access info)- Resolved by Jakub Kremer
Hi @shpeng,
the changes look good to me. Can you please give a bit more detail about the changes in the MR description?
Also, I noticed your
athena-2
fork does not have theatlasbot
added as developer. Can you please add it, so that the pipeline status will be displayed correctly for future MRs from this fork?The CI has a CMake warning:
CMake Warning at /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Database/ConnectionManagement/AtlasAuthentication/CMakeLists.txt:37 (message): The required authentication file /afs/cern.ch/atlas/offline/external/AtlasAuth/v22/authentication.xml does not exist!
that seems completely unrelated to your changes. I'm also not sure why it showed up, since I can see this file e.g. from lxplus. Just to be on the safe side, I'm going to re-run the CI.
L1 shifter
This merge request affects 1 package:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
This merge request affects 2 files:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY13.py
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY23.py
CI Result SUCCESS (hash e3aa3a49)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9263] (remote access info)added 92 commits
-
e3aa3a49...08719513 - 91 commits from branch
atlas:main
- dcd93de0 - Merge branch athena:main into main
-
e3aa3a49...08719513 - 91 commits from branch
This merge request affects 1 package:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
This merge request affects 2 files:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY13.py
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY23.py
- Resolved by Jakub Kremer
Hi @shpeng,
I actually noticed there was a large MR (!69804 (merged)) aimed at unifying the usage of
flags
instead ofConfigFlags
across derivation formats. Can you please consider to roll back your changes related to this (i.e. do not replaceflags
withConfigFlags
again)?L1 shifter
This merge request affects 1 package:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
This merge request affects 2 files:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY13.py
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY23.py
This merge request affects 1 package:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys
This merge request affects 2 files:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY13.py
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/python/BPHY23.py
CI Result SUCCESS (hash dcd93de0)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9266] (remote access info) CI Result SUCCESS (hash f58ba336)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9271] (remote access info) CI Result SUCCESS (hash d4a5cdb9)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9272] (remote access info)added review-approved label and removed review-pending-level-1 label
mentioned in commit 587a92f4