TRT_GeoModel: code refactoring and cleanup

Affected classes: the Tool and both Factories.

The changes include: the removal of redundant functions and typedefs, refactoring of the headers, switching to ATH_CHECK() macros where possible, switching to Gaudi::Property in the Tool, formatting changes, etc.

No changes in the functionality are expected. This MR is an intermediate step in preparation for more substantial updates that will come in later MRs

added full-integration-tests full-unit-tests labels

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/TRT_GeoModel

This merge request affects 6 files:

• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.h
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Lite.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Lite.h
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRT_DetectorTool.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRT_DetectorTool.h

Adding @cgrefe ,@sroe ,@calfayan ,@goetz as watchers

added InnerDetector main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

112K in file InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx

added 3 commits

• 48c6c610...dc438fb0 - 2 commits from branch atlas:main
• 394ae4dd - TRT_GeoModel: code refactoring and cleanup

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/TRT_GeoModel

This merge request affects 6 files:

• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.h
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Lite.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Lite.h
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRT_DetectorTool.cxx
• InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRT_DetectorTool.h

Adding @sroe ,@cgrefe ,@calfayan ,@goetz as watchers

WARNING: big files (>100K) are found in the changeset

112K in file InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx

Hi @cgrefe, I just wanted to ensure you are aware of these changes. I started all this refactoring of the "old" version of the TRT factory and the Tool to better understand the details of the mechanism we discussed last Monday. I may have more MR-s touching the TRT_GeoModel code in Athena. Once I'm done with it, I will try to implement some patches/hacks in the standalone version to be able to modify the materials in TRT after reading back from SQLite.

Please let me know if you spot any issues with my MR-s. Thanks!

CI Result SUCCESS (hash 48c6c610)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9300] (remote access info)

CI Result SUCCESS (hash 394ae4dd)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9301] (remote access info)

The changes look good and the CI succeeds, approving for L1.

~L1

removed review-pending-level-1 label

added review-approved label

resolved all threads

merged

mentioned in commit a6f2150f