TRTDetectorFactory_Full: changed the way the central barrel is constructed
The goal of this exercise is to test a different approach to the construction of the central barrel. If this mechanism proves to be successful, then a similar strategy will be applied to endcaps, and finally, it will also be implemented in the standalone TRT GeoModel plugin code in the GeoModelATLAS repository.
In the current implementation, we construct one instance of the barrel radiator Serial Transformer per layer for each potential straw material - Xenon, Argon, and Krypton - and then reuse it as many times as needed when constructing the barrel. In the new approach, we don't share Serial Transformers. Instead for each radiator, a new Transformer is created. The memory overhead of the new implementation is negligible (at the level of 0.5% wrt the current one). OTOH, after applying this strategy to the standalone implementation it will be possible to patch the materials of individual modules after reading the persistent description from SQLite.
CC @cgrefe
Merge request reports
Activity
added full-integration-tests full-unit-tests labels
added InnerDetector main review-pending-level-1 labels
CI Result SUCCESS (hash eb3fa81e)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9332] (remote access info)- Resolved by Vakhtang Tsulaia
Thanks @tsulaia. In case it helps: the minimum granularity in which we can change the active gas is per layer (see https://twiki.cern.ch/twiki/pub/Atlas/TRT_geometries/GasGeometries.png), i.e. 3 barrel layers and 14 endcap layers on each side.
added review-pending-level-2 label and removed review-pending-level-1 label
removed review-pending-level-2 label
added 30 commits
-
eb3fa81e...8e89f61c - 29 commits from branch
atlas:main
- 87ba1da3 - TRTDetectorFactory_Full: changed the way the central barrel is constructed
-
eb3fa81e...8e89f61c - 29 commits from branch
added 1 commit
- c94024b1 - TRTDetectorFactory_Full: more refactoring of the code
This merge request affects 1 package:
- InnerDetector/InDetDetDescr/TRT_GeoModel
This merge request affects 2 files:
- InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx
- InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.h
CI Result SUCCESS (hash c94024b1)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9410] (remote access info)This merge request affects 1 package:
- InnerDetector/InDetDetDescr/TRT_GeoModel
This merge request affects 2 files:
- InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.cxx
- InnerDetector/InDetDetDescr/TRT_GeoModel/src/TRTDetectorFactory_Full.h
added review-pending-level-1 label
added review-pending-level-2 label and removed review-pending-level-1 label
CI Result SUCCESS (hash c94024b1)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9431] (remote access info)removed review-pending-level-2 label
added review-pending-level-2 label
Ready to be reviewed. I'm bringing back the review-pending-level-2 label that was added by L1 a few days ago
added review-approved label and removed review-pending-level-2 label
mentioned in commit bc38b27f