TrigP1Test: Move Cosmics T0Mon tests to RAWtoALL workflow, fix PhysP1 T0Mon HistCount & RootComp tests (ATR-28781)

changed title from Draft: TrigP1Test: Adjust output hist file name to match... to Draft: TrigP1Test: Move Cosmics T0Mon tests to RAWtoALL workflow, fix PhysP1 T0Mon HistCount & RootComp tests (ATR-28781)

changed the description

I pinged @stelzer & @okumura about this this morning but realised that maybe @martindl and @carquin are the ones who should give this a review. Beside changing the Cosmics workflow to RAWtoALL, I also made modifications to the test_trigP1_v1PhysP1_T0Mon* tests. This is because it seemed RootComp and HistCount were failing, because the input hist file does not exist (they're configured to check "ExampleMonitorOutput.root" but the test outputs "hist.root"?) To make it find both the test and reference hist files for RootComp, I adjusted the tzreco tests to output ExampleMonitorOutput.root instead.

After the adjustment, the tests work but maybe the reference files are outdated? I now get the following output for these tests:

<head/tail> test_trigP1_v1PhysP1_T0Mon_build/fixed/RootComp.log 
Styles set by rootlogin.C 
----------------------------------------------------------------------
Command    : rootcomp.py /eos/atlas/atlascerngroupdisk/data-art/grid-input/TrigP1Test/ref/24.0/test_trigP1_v1PhysP1_T0Mon_build/ExampleMonitorOutput.root ExampleMonitorOutput.root

Reference  : /eos/atlas/atlascerngroupdisk/data-art/grid-input/TrigP1Test/ref/24.0/test_trigP1_v1PhysP1_T0Mon_build/ExampleMonitorOutput.root
File       : ExampleMonitorOutput.root
Comparison : BIN-BY-BIN (1.0e-06)
Ignored histograms: Unpck$, BufFreeCnt$, CalEvtSize$, /TIME_, /athenaHLT.*/.*Time$, HltEventLoopMgr/.*Time.*, HltEventLoopMgr/PopScheduler.*, MessageSvc/MessageCount, TrigSignatureMoni/.*Rate, TrigOpMonitor/GeneralOpInfo, TrigOpMonitor/IOVDb.*, TrigOpMonitor/.*ReadTime, TrigOpMonitor/.*BytesRead, HLTFramework/ROBDataProviderSvc, HLTFramework/SchedulerMonSvc, HLTSeeding/Random
----------------------------------------------------------------------
Error in <TFile::cd>: Unknown directory run_440499
...
Error in <TFile::cd>: Unknown directory run_440499
Error in <TFile::cd>: Unknown directory run_440499

Summary:
========
Total histograms compared: 0
Missing references: 54942
Matching histograms: 0
Different histograms: 0
Ignored histograms: 13

Comparison results written to rootcomp.root
Comparison results written to rootcomp.ps
Overall test result: 255

If it's a matter of reference update, I assume the MR can go in regardless.

Undrafting (for CI) but setting to user review needed for now.

marked this merge request as ready

changed the description

Jenkins please retry a build

added review-user-action-required label

This merge request affects 1 package:

Trigger/TrigValidation/TrigP1Test

This merge request affects 5 files:

Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_grid.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0MonTrf_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_grid.py

Adding @salderwe ,@aporeba ,@okumura ,@martindl ,@vmartin as watchers

added 24.0 Trigger review-pending-level-1 labels and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash abcc62b5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9373] (remote access info)

Sorry, another consequence of the accidental removal of the ttbar RDO (ATR-29364). It's now back.

Jenkins please retry a build

This merge request affects 1 package:

Trigger/TrigValidation/TrigP1Test

This merge request affects 5 files:

Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_grid.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0MonTrf_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_grid.py

Adding @okumura ,@vmartin ,@salderwe ,@martindl ,@aporeba as watchers

CI Result SUCCESS (hash abcc62b5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9393] (remote access info)

Sorry @cantel - this has clashed with !71286 (merged) and will need conflict resolution

added 37 commits

abcc62b5...35e10d10 - 34 commits from branch atlas:24.0
673197d7 - test_trigP1_v1PhysP1_T0Mon: Adjust output hist file name to match configs and existing reference
251033b5 - test_trigP1_v1PhysP1_T0MonTrf_build: Adjust output hist file name to match...
07fd162e - test_trigP1_v1Cosmic_T0Mon: Move to RAWtoALL workflow

Compare with previous version

This merge request affects 1 package:

Trigger/TrigValidation/TrigP1Test

This merge request affects 5 files:

Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Cosmic_T0Mon_grid.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0MonTrf_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_build.py
Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_T0Mon_grid.py

Adding @okumura ,@salderwe ,@vmartin ,@martindl ,@aporeba as watchers

CI Result SUCCESS (hash 07fd162e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9432] (remote access info)

added review-approved review-approved-point1 labels

TrigP1Test: Move Cosmics T0Mon tests to RAWtoALL workflow, fix PhysP1 T0Mon HistCount & RootComp tests (ATR-28781)

Merge request reports

Activity