FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.

Copying values in range-for. Potential use of invalidated iterators. Prefer range-for. sprintf format/argument match. sprintf buffer size. Pass objects by const reference, not by value. Prefer returning const references to members rather than copies.

This merge request affects 1 package:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms

This merge request affects 4 files:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimMapMakerAlg.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimMapMakerAlg.h
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/TrackFitter.h

added EFTracking Trigger main review-pending-level-1 labels

CI Result SUCCESS (hash db1ef531)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9402] (remote access info)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit dc148959