FPGATrackSimMaps: Fix cppcheck warnings.

Out-of-bounds array accesses. Redundant map lookup. Copying values in range-for.

This merge request affects 1 package:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps

This merge request affects 3 files:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps/src/FPGATrackSimRegionMap.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps/src/FPGATrackSimSectorMap.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps/src/FPGATrackSimSpacePointsTool.cxx

Adding @sutt ,@nagano as watchers

added EFTracking Trigger main review-pending-level-1 labels

CI Result SUCCESS (hash 2e2e3461)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9403] (remote access info)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit b769df19