Update IBarcodeSvc implementations to properly handle quasi-stable particles

Here the idea is to make the barcode service handle the aspects of barcode setting which require looking at the whole GenEvent to avoid overlaps. This is an alternative approach to the changes in !71238 (closed).

Tagging @pclark and @averbyts

Jenkins please retry a build

This merge request affects 7 packages:

• Simulation/Barcode/BarcodeInterfaces
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/ISF/ISF_Core/ISF_Algorithms
• Simulation/ISF/ISF_Core/ISF_Interfaces
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools

Affected files list will not be printed in this case

Adding @lmijovic ,@zhangr ,@schaarsc ,@tadej ,@jbeirer ,@jchapman as watchers

added Simulation main labels

added 1 commit

• caae2ed1 - MagicNumbers.h: directly use BarcodeBased versions of helper functions when...

Compare with previous version

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash a972ae77)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9462] (remote access info)

added 1 commit

• 98e987a2 - Update ISF_FatrasTools:PhotonConversionTool_test

Compare with previous version

Jenkins please retry a build

This merge request affects 9 packages:

• Generators/TruthUtils
• Simulation/Barcode/BarcodeInterfaces
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/ISF/ISF_Core/ISF_Algorithms
• Simulation/ISF/ISF_Core/ISF_Interfaces
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools
• Simulation/ISF/ISF_Fatras/ISF_FatrasTools

Affected files list will not be printed in this case

Adding @lmijovic ,@zmarshal ,@zhangr ,@schaarsc ,@jbeirer ,@tadej ,@jchapman ,@tcuhadar as watchers

added Egamma Generators analysis-review-required labels

CI Result SUCCESS (hash 98e987a2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9472] (remote access info)

marked this merge request as ready

This merge request affects 9 packages:

• Generators/TruthUtils
• Simulation/Barcode/BarcodeInterfaces
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasAlg
• Simulation/ISF/ISF_Core/ISF_Algorithms
• Simulation/ISF/ISF_Core/ISF_Interfaces
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools
• Simulation/ISF/ISF_Fatras/ISF_FatrasTools

Affected files list will not be printed in this case

Adding @lmijovic ,@schaarsc ,@zmarshal ,@tadej ,@jchapman ,@zhangr ,@jbeirer ,@tcuhadar as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 98e987a2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9498] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving

Cheers, Qiyu, L1

removed review-pending-level-1 label

added review-approved label

I don't believe we use the BarCodeSvc for analysis. Approving for AR.

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit c329bcd6