Skip to content
Snippets Groups Projects

Creating JETM42 derivation (DADs)

Merged Dylan Sheldon Rankin requested to merge drankin/athena:jetm42_phys into main
All threads resolved!

This MR creates a new JETM42 derivation format based on the PHYS format that additionally includes clusters and towers as well as jets built from them. This derivation is intended for use in Upgrade studies.

@sch @htorre @mswiatlo @kleney @tamartin @tmhong

Merge request reports

Pipeline #7398302 passed

Pipeline passed for 43cabb3c on drankin:jetm42_phys

Approval is optional

Merged by Tadej NovakTadej Novak 10 months ago (May 17, 2024 11:37am UTC)

Merge details

  • Changes merged into main with 6e7d6bb2.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dylan Sheldon Rankin resolved all threads

    resolved all threads

  • added 1 commit

    • bf665268 - removing comments, fixing copyright

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

    Affected files list will not be printed in this case

    Adding @jveatch ,@jcatmore ,@emmat ,@nelsonc ,@jmellent ,@ispokhar as watchers

  • :white_check_mark: CI Result SUCCESS (hash bf665268)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9599] (remote access info)

  • @drankin, please find some additional comments from the review. In particular, the compilation warnings caused by unused imports need to be fixed.

    L1 shifter

  • added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

    Affected files list will not be printed in this case

    Adding @jmellent ,@ispokhar ,@emmat ,@nelsonc ,@jveatch ,@jcatmore as watchers

  • added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

    Affected files list will not be printed in this case

    Adding @emmat ,@jcatmore ,@jveatch ,@jmellent ,@nelsonc ,@ispokhar as watchers

  • @jkremer Thanks a lot for the comments! I have addressed them all with the recent commits.

  • :white_check_mark: CI Result SUCCESS (hash 26092bc2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9679] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 43cabb3c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9680] (remote access info)

  • added Upgrade label

  • Thomas Strebler resolved all threads

    resolved all threads

  • Looks good, approving - L2

  • merged

  • Tadej Novak mentioned in commit 6e7d6bb2

    mentioned in commit 6e7d6bb2

  • Please register or sign in to reply
    Loading