Skip to content
Snippets Groups Projects

Revive the Muon effi SF tester macro

Merged Revive the Muon effi SF tester macro
jojungge/athena:SagarNeedsToBeHappy into main
All threads resolved!
Merged Johannes Junggeburth requested to merge jojungge/athena:SagarNeedsToBeHappy into main
All threads resolved!
  • Revive the tester macro to compare the scale-factors per muon in different recommendation releases. Macro is now based on the MuonTesterTree package.
  • Delete obsolete tester algorithms
  • Introduce a CA config

Tagging @sagara17, @goblirsc, @sagar, @vaustrup, @gproto

Edited by Johannes Junggeburth

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Tadej NovakTadej Novak 10 months ago (May 15, 2024 6:00am UTC)

Merge details

  • Changes merged into main with d3f1f08f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • b14d87fd - Yeeeeees there's a pile-up CA configuration

    Compare with previous version

  • Johannes Junggeburth changed the description

    changed the description

  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • Johannes Junggeburth marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections

    This merge request affects 14 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/CMakeLists.txt
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/MuonEfficiencyCorrections/MuonSFTestHelper.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonSFTestHelper.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonTriggerScaleFactors.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/python/MuonEfficiencyCorrectionsCfg.py
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/components/MuonEfficiencyCorrections_entries.cxx

    Adding @sangelid ,@vaustrup ,@jojungge ,@nakahama ,@nicolaid ,@apsallid as watchers

  • ATLAS Robot added Analysis Trigger analysis-review-required main review-pending-level-1 labels

    added Analysis Trigger analysis-review-required main review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 171ee606)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9509] (remote access info)

  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections

    This merge request affects 14 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/CMakeLists.txt
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/MuonEfficiencyCorrections/MuonSFTestHelper.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonSFTestHelper.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonTriggerScaleFactors.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/python/MuonEfficiencyCorrectionsCfg.py
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/components/MuonEfficiencyCorrections_entries.cxx

    Adding @nakahama ,@nicolaid ,@apsallid ,@vaustrup ,@jojungge ,@sangelid as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 84ce9999)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9519] (remote access info)

  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections

    This merge request affects 15 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/CMakeLists.txt
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/MuonEfficiencyCorrections/MuonSFTestHelper.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonSFTestHelper.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonTriggerScaleFactors.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/python/MuonEfficiencyCorrectionsCfg.py
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonEfficiencyCorrections_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonScaleFactorTestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/MuonTriggerSF_TestAlg.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/TestTrigSF.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/src/components/MuonEfficiencyCorrections_entries.cxx
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/util/MuonEfficiencyScaleFactorsSFFileTester.cxx

    Adding @nakahama ,@sangelid ,@vaustrup ,@jojungge ,@apsallid ,@nicolaid as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1f0c1eaa)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9530] (remote access info)

  • Edson Carquin Lopez
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Edson Carquin Lopez
    Edson Carquin Lopez @carquin ·
    Developer

    Looks good, approving --L1

  • Edson Carquin Lopez added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • K
    Nils Erik Krumnack @krumnack ·
    Developer

    This looks like a pure test update, approving for AR.

    Nils [Analysis RC]

  • Nils Erik Krumnack added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Sagar Addepalli resolved all threads

    resolved all threads

  • Tadej Novak mentioned in commit d3f1f08f

    mentioned in commit d3f1f08f

  • Tadej Novak merged

    merged

    • Please register or sign in to reply