Drop unused concept of shared child particle barcodes
A long time ago, there was the idea that all child particles produced in a decay could be assigned the same barcode. This schema was never used and now we are migrating away from barcodes generally it seems like a good time to clean this unused code up.
-
TruthSvc
: DropsetSharedChildParticleBarcode
method -
IBarcodeSvc
+ implementations: DropsharedChildBarcode
method -
ITruthIncident
+ implementations: DropsetAllChildrenBarcodes
method -
ISFParticle
: Drop unusedsetBarcodeAndUpdateHepMcParticleLink
method (this was only called byISFTruthIncident::setAllChildrenBarcodes
)
Merge request reports
Activity
added 182 commits
-
c26cce9a...adf04ab5 - 178 commits from branch
atlas:main
- f5ea2f4b - TruthSvc: Drop deprecated setSharedChildParticleBarcode method
- b0d33390 - IBarcodeSvc: remove obsolete sharedChildBarcode method
- 58fe8e72 - Drop ITruthIncident::setAllChildrenBarcodes
- 4b682805 - ISFParticle: Drop unused setBarcodeAndUpdateHepMcParticleLink method
Toggle commit list-
c26cce9a...adf04ab5 - 178 commits from branch
This merge request affects 5 packages:
- Simulation/Barcode/BarcodeInterfaces
- Simulation/Barcode/BarcodeServices
- Simulation/ISF/ISF_Core/ISF_Event
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Geant4/ISF_Geant4Event
Affected files list will not be printed in this case
added Simulation main review-pending-level-1 labels
CI Result FAILURE (hash 4b682805)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9566] (remote access info)removed review-pending-level-1 label
added 1 commit
- ef4f2160 - Update TruthSvc_test to reflect altered pattern of calls to TruthIncident methods
added 25 commits
-
ef4f2160...7e4a35ef - 20 commits from branch
atlas:main
- 20ddebf1 - TruthSvc: Drop deprecated setSharedChildParticleBarcode method
- 7fcce0ad - IBarcodeSvc: remove obsolete sharedChildBarcode method
- 7bb702dc - Drop ITruthIncident::setAllChildrenBarcodes
- 1ce89e1f - ISFParticle: Drop unused setBarcodeAndUpdateHepMcParticleLink method
- 283fb341 - Update TruthSvc_test to reflect altered pattern of calls to TruthIncident methods
Toggle commit list-
ef4f2160...7e4a35ef - 20 commits from branch
This merge request affects 5 packages:
- Simulation/Barcode/BarcodeInterfaces
- Simulation/Barcode/BarcodeServices
- Simulation/ISF/ISF_Core/ISF_Event
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Geant4/ISF_Geant4Event
Affected files list will not be printed in this case
added review-pending-level-1 label
CI Result SUCCESS (hash 283fb341)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9592] (remote access info)