From 2382c2ce471e87690f2983b628e8bba0629c46c2 Mon Sep 17 00:00:00 2001
From: scott snyder <sss@karma>
Date: Tue, 13 Feb 2024 11:51:49 -0500
Subject: [PATCH] ForwardTracker: Fix cppcheck 2.14 warnings.
Prefer returning const references to members rather than copies.
Pass object by const reference, not by value.
---
.../ForwardTracker/ForwardTracker/ForwardTrack.h | 10 +++++-----
ForwardDetectors/ForwardTracker/src/ForwardTrack.cxx | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/ForwardDetectors/ForwardTracker/ForwardTracker/ForwardTrack.h b/ForwardDetectors/ForwardTracker/ForwardTracker/ForwardTrack.h
index c064c5b6ef8f..113c0dae464e 100644
--- a/ForwardDetectors/ForwardTracker/ForwardTracker/ForwardTrack.h
+++ b/ForwardDetectors/ForwardTracker/ForwardTracker/ForwardTrack.h
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
#ifndef ForwardTrack_H
@@ -16,13 +16,13 @@ class ForwardTrack {
ForwardTrack();
- void initialize(ForwardTracker::ConfigData);
+ void initialize(const ForwardTracker::ConfigData&);
bool TrackParticle(ForwardTracker::Particle);
- inline ForwardTracker::Point fPos() { return m_fPosition; }
- inline ForwardTracker::Point fMom() { return m_fMomentum; }
- inline ForwardTracker::Particle fPar() { return m_fParticle; }
+ inline const ForwardTracker::Point& fPos() { return m_fPosition; }
+ inline const ForwardTracker::Point& fMom() { return m_fMomentum; }
+ inline const ForwardTracker::Particle& fPar() { return m_fParticle; }
private:
diff --git a/ForwardDetectors/ForwardTracker/src/ForwardTrack.cxx b/ForwardDetectors/ForwardTracker/src/ForwardTrack.cxx
index c0561543b33e..8e86eb315a57 100644
--- a/ForwardDetectors/ForwardTracker/src/ForwardTrack.cxx
+++ b/ForwardDetectors/ForwardTracker/src/ForwardTrack.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
#include "ForwardTracker/BeamlineSetup.h"
@@ -11,7 +11,7 @@ ForwardTrack::ForwardTrack()
{
}
-void ForwardTrack::initialize(ForwardTracker::ConfigData cData) {
+void ForwardTrack::initialize(const ForwardTracker::ConfigData& cData) {
std::cout << " ForwardTrack::initialize " << std::endl;
std::cout << " ConfigData " << cData;
--
GitLab