ISFTruthIncident / ISF_Fatras - Improve robustness + fix warnings

The changes in this merge request should finally fix the many warnings seen when running simulation using ISF_Fatras. There are two main sets of changes:

1. ISFTruthIncident: Add methods to properly update ISFParticles after the Truth Incident has been registered with the TruthSvc. The ISFTruthIncident::updateHepMCTruthParticle() method was changed to only update the ISF::TruthBinding of the ISFParticle in question. This is because a valid (GenParticle::)id value and hence a valid HepMcParticleLink can only be obtained after a new GenParticle has been added to the GenEvent - this occurs within the TruthSvc, not within the ISFTruthIncident. Instead ISFTruthIncident::updateParentAfterIncidentProperties() and ISFTruthIncident::updateChildParticleProperties() can be called to sync up the ISFParticle properties after the call to TruthSvc::registerTruthIncident(). These handle all cases except the case where the parent particle survives the interaction, but is not recorded to the GenEvent (for a follow-up MR).
2. Updates to ISF_Fatras classes (+ FastCaloSimV2Tool). All ISFParticles for secondaries created by Fatras should not have barcode/id/truthBinding/particleLink set initially. These should be set by the calls to TruthSvc::registerTruthIncident(), ISFTruthIncident::updateParentAfterIncidentProperties() and ISFTruthIncident::updateChildParticleProperties(). These calls should all be made before any particles are passed back to the ParticleBroker. No TruthBinding for secondaries should be set directly by the ISF_Fatras code. (NB For the special case of particles being returned to the ParticleBroker having not interacted, then the returned ISFParticle should have the same barcode/id/truthBinding/particleLink as the initial ISFParticle - this has to be set manually in the McMaterialEffectsUpdator code.

(Note to review shifters - it's probably best to review this with whitespace changes switched off. The ISF_Fatras classes need a larger clean-up, but that is beyond the scope of this merge request.)

Simulation/ISF/ISF_Fatras/ISF_FatrasTools/src/ProcessSamplingTool.cxx

@@ -11,7 +11,7 @@
 #include "ISF_Event/ISFParticle.h"
 #include "ISF_Event/ISFTruthIncident.h"
 #include "ISF_Interfaces/ITruthSvc.h"
-#include "TruthUtils/MagicNumbers.h"
+#include "TruthUtils/HepMCHelpers.h"
 // iFatras
 #include "ISF_FatrasInterfaces/IHadronicInteractionProcessor.h"
 #include "ISF_FatrasInterfaces/IPhysicsValidationTool.h"
@@ -258,27 +258,28 @@ ISF::ISFParticleVector  iFatras::ProcessSamplingTool::interact(const ISF::ISFPar
     // double cTh = 1.-fmin/(1.-fr)/fr;
 
     // first implementation: ctH=1 
-
+    const int status = 1 + HepMC::SIM_STATUS_THRESHOLD;
+    const int id = HepMC::UNDEFINED_ID; // This will be set if the child particle is saved to the GenEvent
     ISF::ISFParticle* child1 = new ISF::ISFParticle( position,
-                                        fr*momentum,
-                                        0.,
-                                        0.,
-                                        22,
-                                        1 + HepMC::SIM_STATUS_THRESHOLD,
-                                        eCell.time,
-                                        *parent,
-                                                     0 // FIXME hard-coded id
+                                                     fr*momentum,
+                                                     0.,
+                                                     0.,
+                                                     MC::PHOTON,
+                                                     status,
+                                                     eCell.time,
+                                                     *parent,
+                                                     id
                                                      );
 
     ISF::ISFParticle* child2 = new ISF::ISFParticle( position,
-                                        (1-fr)*momentum,
-                                        0.,
-                                        0.,
-                                        22,
-                                        1 + HepMC::SIM_STATUS_THRESHOLD,
-                                        eCell.time,
-                                        *parent,
-                                                     0 // FIXME hard-coded id
+                                                     (1-fr)*momentum,
+                                                     0.,
+                                                     0.,
+                                                     MC::PHOTON,
+                                                     status,
+                                                     eCell.time,
+                                                     *parent,
+                                                     id
                                                      );
 
     childVector.push_back(child1);     
@@ -323,7 +324,8 @@ ISF::ISFParticleVector  iFatras::ProcessSamplingTool::interact(const ISF::ISFPar
 			       ISF::fKillsPrimary );
   m_truthRecordSvc->registerTruthIncident( truth);
 
-  //Make sure the conversion products get a chance to have correct truth info before pushing into the particle broker
+  // Make sure the conversion products get a chance to have correct truth info before pushing into the particle broker
+  // FIXME Check this doesn't cause problems in the TruthSvc
   for (unsigned int i=0; i<childVector.size(); i++) {
      if (!childVector[i]->getTruthBinding()) {
          childVector[i]->setTruthBinding(new ISF::TruthBinding(*parent->getTruthBinding()));
@@ -393,8 +395,13 @@ ISF::ISFParticleVector  iFatras::ProcessSamplingTool::interact(const ISF::ISFPar
 			       parent->nextGeoID(),  // inherits from the parent
 			       ISF::fKillsPrimary );
   m_truthRecordSvc->registerTruthIncident( truth);
+  // At this point we need to update the properties of the
+  // ISFParticles produced in the interaction
+  truth.updateParentAfterIncidentProperties();
+  truth.updateChildParticleProperties();
 
   //Make sure the conversion products get a chance to have correct truth info before pushing into the particle broker
+  // FIXME check this doesn't cause problems later
   for (unsigned int i=0; i<childVector.size(); i++) {
       if (!childVector[i]->getTruthBinding()) {
           childVector[i]->setTruthBinding(new ISF::TruthBinding(*parent->getTruthBinding()));