ISFTruthIncident / ISF_Fatras - Improve robustness + fix warnings
-
Review changes -
-
Download -
Patches
-
Plain diff
The changes in this merge request should finally fix the many warnings seen when running simulation using ISF_Fatras. There are two main sets of changes:
- ISFTruthIncident: Add methods to properly update ISFParticles after the Truth Incident has been registered with the TruthSvc. The
ISFTruthIncident::updateHepMCTruthParticle()
method was changed to only update the ISF::TruthBinding of the ISFParticle in question. This is because a valid (GenParticle::
)id value and hence a valid HepMcParticleLink can only be obtained after a new GenParticle has been added to the GenEvent - this occurs within the TruthSvc, not within the ISFTruthIncident. InsteadISFTruthIncident::updateParentAfterIncidentProperties()
andISFTruthIncident::updateChildParticleProperties()
can be called to sync up the ISFParticle properties after the call toTruthSvc::registerTruthIncident()
. These handle all cases except the case where the parent particle survives the interaction, but is not recorded to the GenEvent (for a follow-up MR). - Updates to ISF_Fatras classes (+
FastCaloSimV2Tool
). All ISFParticles for secondaries created by Fatras should not have barcode/id/truthBinding/particleLink set initially. These should be set by the calls toTruthSvc::registerTruthIncident()
,ISFTruthIncident::updateParentAfterIncidentProperties()
andISFTruthIncident::updateChildParticleProperties()
. These calls should all be made before any particles are passed back to the ParticleBroker. No TruthBinding for secondaries should be set directly by the ISF_Fatras code. (NB For the special case of particles being returned to the ParticleBroker having not interacted, then the returned ISFParticle should have the same barcode/id/truthBinding/particleLink as the initial ISFParticle - this has to be set manually in theMcMaterialEffectsUpdator
code.
(Note to review shifters - it's probably best to review this with whitespace changes switched off. The ISF_Fatras classes need a larger clean-up, but that is beyond the scope of this merge request.)
Edited by John Derek Chapman
Merge request reports
Compare and
- version 21855b3914
- version 20e40e6600
- version 19026b54a3
- version 18c44cbd97
- version 17a19525cf
- version 167192b01c
- version 159a3c4534
- version 140b017e20
- version 131531bb26
- version 12bf6fd2ed
- version 11109895fe
- version 108a88e8f6
- version 90b38ee77
- version 8e1fc0f40
- version 7cd760c87
- version 6909136cf
- version 56c2a5c96
- version 4bca657e6
- version 30fd2f585
- version 28b9e6e19
- version 1c7c38559
- main (base)
- latest version4d2568318 commits,
- version 21855b39148 commits,
- version 20e40e66009 commits,
- version 19026b54a311 commits,
- version 18c44cbd9711 commits,
- version 17a19525cf8 commits,
- version 167192b01c10 commits,
- version 159a3c453410 commits,
- version 140b017e209 commits,
- version 131531bb2610 commits,
- version 12bf6fd2ed7 commits,
- version 11109895fe7 commits,
- version 108a88e8f67 commits,
- version 90b38ee777 commits,
- version 8e1fc0f406 commits,
- version 7cd760c876 commits,
- version 6909136cf5 commits,
- version 56c2a5c964 commits,
- version 4bca657e64 commits,
- version 30fd2f5852 commits,
- version 28b9e6e194 commits,
- version 1c7c385594 commits,
Compare changes
- Side-by-side
- Inline
Files
13Loading