ISF_Fatras: fix status values for secondaries produced by ISF_Fatras

Cleaned-up the setting of initial properties of ISFParticles created for secondary particles created by ISF_Fatras. Mostly this is related to setting the status correctly and (for now) explicitly setting the ISFParticle::id to HepMC::UNDEFINED_ID. (In future this will be set by the ISFTruthIncident - see !71407 (merged)).

This MR also adds some FIXME comments to be followed up in future MRs.

Tagging @dduda and @pclark.

This merge request affects 2 packages:

• Simulation/ISF/ISF_Fatras/ISF_FatrasTools
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4

Affected files list will not be printed in this case

Adding @lmijovic ,@tcuhadar ,@jchapman as watchers

added Egamma Simulation main review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 8dcc94e2)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9622] (remote access info)

Apart from the compilation errors, the changes look good. @jchapman, can you please have a look at the errors?

L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

marked this merge request as draft

added 1 commit

• 291f8013 - ISF_Fatras: fix status values for secondaries produced by ISF_Fatras

Compare with previous version

resolved all threads

marked this merge request as ready

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 2 packages:

• Simulation/ISF/ISF_Fatras/ISF_FatrasTools
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4

Affected files list will not be printed in this case

Adding @lmijovic ,@jchapman ,@tcuhadar as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 291f8013)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9639] (remote access info)

Looks good, approving --L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c2b9658e