Skip to content
Snippets Groups Projects

CPAlgorithms: two fixes for the global trigger SFs

Merged CPAlgorithms: two fixes for the global trigger SFs
ravinab/athena:fix_triggerSF into main
All threads resolved!
Merged Baptiste Ravina requested to merge ravinab/athena:fix_triggerSF into main
All threads resolved!

!70292 (merged) introduced the new option multiTriggerChainsPerYear which is unfortunately currently preventing the global trigger SF config block from being set up properly: the first commit in this MR addresses that.

The second issue is that single-electron trigger SFs are not retrieved properly (zero effect of systematics). This is fixed by registering all the electron/photon tools with the systematics service in the algorithm and adapting the relevant part of the global trigger tool. Thanks a lot to @jmaurer for his help with this fix!

Edited by Baptiste Ravina

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Baptiste Ravina resolved all threads

    resolved all threads

  • Baptiste Ravina added 1 commit

    added 1 commit

    • 0f603ffe - register also the systematics from the SF tools

    Compare with previous version

  • Baptiste Ravina changed the description

    changed the description

  • Baptiste Ravina added 1 commit

    added 1 commit

    Compare with previous version

  • Baptiste Ravina marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
    • PhysicsAnalysis/Algorithms/TriggerAnalysisAlgorithms
    • Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

    Affected files list will not be printed in this case

    Adding @tadej ,@krumnack as watchers

  • ATLAS Robot added Analysis CPAlgorithms Trigger analysis-review-required main review-pending-level-1 labels

    added Analysis CPAlgorithms Trigger analysis-review-required main review-pending-level-1 labels

  • Marco Rimoldi added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Marco Rimoldi
    Marco Rimoldi @mrimoldi ·
    Developer

    Approving, Marco (AR shifter)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 00e36629)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9663] (remote access info)

  • Tadej Novak removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Tadej Novak added review-approved label

    added review-approved label

  • Tadej Novak mentioned in commit ee70a92a

    mentioned in commit ee70a92a

  • Tadej Novak merged

    merged

  • Thomas Strebler mentioned in merge request easyjet/easyjet!739 (merged)

    mentioned in merge request easyjet/easyjet!739 (merged)

    • Please register or sign in to reply