Skip to content
Snippets Groups Projects

MuonEventCnvTools: Remove detStore retrieve of MuonDetectorManager

Merged MuonEventCnvTools: Remove detStore retrieve of MuonDetectorManager
emoyse/athena:main_remove_detstore_retrieve into main
All threads resolved!
Merged Edward Moyse requested to merge emoyse/athena:main_remove_detstore_retrieve into main
All threads resolved!

I think this is not needed any more, but I will request full-unit-tests in case I am wrong and there is some edge case which this supports.

cc @jojungge

Merge request reports

Pipeline #7396503 passed

Stage: external

Pipeline passed for 655be9e8 on emoyse:main_remove_detstore_retrieve

Approval is optional

Merged by Tadej NovakTadej Novak 11 months ago (May 16, 2024 3:58pm UTC)

Merge details

  • Changes merged into main with 7289896f (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonCnv/MuonEventCnvTools

    This merge request affects 2 files:

    • MuonSpectrometer/MuonCnv/MuonEventCnvTools/src/MuonEventCnvTool.cxx
    • MuonSpectrometer/MuonCnv/MuonEventCnvTools/src/MuonEventCnvTool.h

    Adding @apsallid ,@kluit ,@pscholer ,@stavrop ,@jojungge ,@rosati as watchers

  • Edward Moyse added 1 commit

    added 1 commit

    Compare with previous version

  • Edward Moyse resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonCnv/MuonEventCnvTools

    This merge request affects 2 files:

    • MuonSpectrometer/MuonCnv/MuonEventCnvTools/src/MuonEventCnvTool.cxx
    • MuonSpectrometer/MuonCnv/MuonEventCnvTools/src/MuonEventCnvTool.h

    Adding @apsallid ,@stavrop ,@jojungge ,@pscholer ,@kluit ,@rosati as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f9d4e856)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9655] (remote access info)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash bff00805)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9656] (remote access info)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 655be9e8)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9657] (remote access info)

  • Tadej Novak removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Tadej Novak added review-approved label

    added review-approved label

  • Tadej Novak merged

    merged

  • Tadej Novak mentioned in commit 7289896f

    mentioned in commit 7289896f

    • Please register or sign in to reply