DerivationFrameworkTau, tauRec, tauRecTools: optimise muon-tau removal sequence
Hello,
This MR is addressing the CPU increase in DAOD_PHYS/LITE reported in ATLASG-2712 coming from the recent addition of GNTau ID. The main changes are in TauAODRunnerAlg, which first runs a tool to remove muon tracks and clusters associated with tau candidates, then reruns most of the tau reconstruction with muon-free inputs. Now, in the muon-tau removal, if no muon track nor cluster is found near the tau, we discard the tau candidate by effectively removing it from the container. This prevents afterburner tools like GNN tau ID from running over the full container (which currently includes irrelevant tau candidates removed later on by a thinning algorithm), thereby saving CPU. I've checked that the TauJets_MuonRM_TauIDDecorKernel CPU time is reduced, it's no longer visible in the SPOT test summary. The DAOD output is unchanged (checked over 1000 events).
There are other minor code cleanups (renaming ConfigFlags->flags) or improvements (e.g. take out some calculation outside a loop in TauIDDecoratorWrapper, introduce a flag to avoid hardcoding the thinning pt cut).
Adding the urgent flag in case it would arrive in time for the imminent DAOD bulk prod.
Tagging @ademaria , @lfiorini , @ntamir , @emmat .
Cheers, Bertrand
Merge request reports
Activity
added urgent label
This merge request affects 4 packages:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
- Reconstruction/tauRec
- Reconstruction/tauRecTools
Affected files list will not be printed in this case
Adding @goetz ,@zmarshal ,@jcatmore ,@emmat ,@dshope ,@adbailey ,@xiaozhon ,@martindl as watchers
removed review-pending-level-1 label
added review-approved label
CI Result SUCCESS (hash 6899bfff)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9733] (remote access info)added analysis-review-approved label and removed analysis-review-required label
mentioned in commit f5d9567a
mentioned in merge request !71621 (merged)
mentioned in merge request !75591 (merged)