MuonReadoutGeometry - Plugin all subvolumes

Should fix exceptions in the R4 -> legacy readout geometry conversion

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 1 file:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MMReadoutElement.cxx

Adding @pscholer ,@rosati ,@jojungge ,@stavrop ,@kluit ,@apsallid as watchers

added MuonSpectrometer main review-pending-level-1 labels

Hey @jojungge - is getAllSubVolumes in the repo? For me this doesn't compile in main, latest...

/home/emoyse.linux/athena/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MMReadoutElement.cxx: In constructor 'MuonGM::MMReadoutElement::MMReadoutElement(GeoVFullPhysVol*, const std::string&, int, int, int, MuonGM::MuonDetectorManager*, const NswPassivationDbData*)':
/home/emoyse.linux/athena/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MMReadoutElement.cxx:95:51: error: 'getAllSubVolumes' was not declared in this scope
   95 |         std::vector<GeoChildNodeWithTrf> children{getAllSubVolumes(pvc)};
      |                                                   ^~~~~~~~~~~~~~~~

It's been merged with the latest !71486 (merged) dump

Ah okay - so you expect this to fail until tomorrow?

It's the first fix. The second one is that the current geometry testing file does not have any micromegas enabled. I've copied a new geometry file to cvmfs and I'm preparing another MR to update the geometry file. Plus, I'm also adding the first unit test for MuonR4.

CI Result SUCCESS (hash 01118309)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9884] (remote access info)

Changes look fine and CI succeeds. Approving for L1.

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 596f3381