TrigServices: Rename HltAsyncEventLoopMgr and drop legacy one

Now that the HltAsyncEventLoopMgr is used by default we can drop the old one and restore the original naming.

Note to reviewers: The are basically no code changes here. Just renaming of HltAsyncEventLoopMgr to HltEventLoopMgr.

cc @ssottoco @smh and relates to ATR-26285.

changed the description

@ssottoco, I prepared this MR. I guess it's safe to get rid of the old EventLoopMgr now?

changed the description

resolved all threads

added full-unit-tests label

marked this merge request as ready

This merge request affects 3 packages:

• Control/StoreGate
• HLT/Trigger/TrigControl/TrigServices
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @fwinkl ,@martindl ,@wiedenma ,@ssnyder ,@fpastore ,@stelzer as watchers

added 24.0 Core Trigger review-pending-level-1 labels

CI Result FAILURE (hash bc937638)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10389] (remote access info)

The removed flag is still used in one place, which leads to CI test errors of this type:

  File "/build2/ci-builds/24.0/Athena/build/Athena/x86_64-el9-gcc13-opt/python/TrigServices/TriggerUnixStandardSetup.py", line 44, in commonServicesCfg
    cfg.merge( AvalancheSchedulerSvcCfg(flags, maxParallelismExtra=1 if flags.Trigger.enableAsyncIO else 0) )

L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

added 145 commits

• bc937638...4fa51b58 - 143 commits from branch atlas:24.0
• 04438080 - TrigServices: Rename HltAsyncEventLoopMgr and drop legacy one
• 0c8a7de2 - StoreGate: remove HltAsyncEventLoopMgr friend declaration

Compare with previous version

This merge request affects 3 packages:

• Control/StoreGate
• HLT/Trigger/TrigControl/TrigServices
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @wiedenma ,@fwinkl ,@ssnyder ,@fpastore ,@martindl ,@stelzer as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 0c8a7de2)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10416] (remote access info)

Changes look good - approving

L1 shifter

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

mentioned in commit 795ebd7c

merged

mentioned in merge request !71857 (merged)