Drop Tracking.cutLevel flag

The Tracking.cutLevel flag was some flag inherited from the distant pass and very unlikely to be configured independently at this stage. Consequently it was just acting as a wrapper around a few other tracking flags, namely

def cutLevel(flags):
        if flags.Tracking.PrimaryPassConfig is PrimaryPassConfig.HeavyIon:
            return 4
        elif flags.Tracking.doLowMu:
            return 3
        elif flags.Beam.Type is BeamType.Cosmics:
            return 8
        elif flags.Tracking.doMinBias:
            return 12
        else:
            return 19

This flag is therefore removed in favour of an explicit configuration of the flags which depend on it.

Moreover ranges functions were built based on it in the TrackingPass flags but those were in most cases anyway overwritten in the actual configuration of the pass, so this was extremely confusing. Those ranges functions are removed as well.

Some changes are implemented for the minimum pT of the track used for photon conversions for non-default configs, so marking this as Reco output changing.

Relevant for ATLASRECTS-7947

FYI @ncalace

added NewConfig Tracking labels

Jenkins please retry a build

changed the description

This merge request affects 1 package:

• Tracking/TrkConfig

This merge request affects 2 files:

• Tracking/TrkConfig/python/TrackingPassFlags.py
• Tracking/TrkConfig/python/TrkConfigFlags.py

Adding @tstreble as watcher

added main label

CI Result FAILURE (hash cb7a7be6)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9927] (remote access info)

added 1 commit

• d346c6bb - Update unit test

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/TrkConfig

This merge request affects 2 files:

• Tracking/TrkConfig/python/TrackingPassFlags.py
• Tracking/TrkConfig/python/TrkConfigFlags.py

Adding @tstreble as watcher

CI Result SUCCESS (hash d346c6bb)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9951] (remote access info)

added 32 commits

• d346c6bb...b7008457 - 28 commits from branch atlas:main
• 18828757 - Remove Tracking.cutLevel flag
• 4eeab4b1 - Remove tracking pass ranges functions
• a150d4f7 - Update unit test
• 84280a0a - Updated Egamma.PhotonConv.TrkSel.minPt flag

Compare with previous version

I knew some misconfiguration were bound to creep in with this cutLevel. As an example

def minPT_ranges( inflags ):
    return select( inflags.Tracking.cutLevel,
    {'-1':   0.1 * Units.GeV,
    '2-13': 0.4 * Units.GeV,
    '14-':  0.5 * Units.GeV } )

returns 0.4 GeV for the HeavyIon config. However, this was explicitly overwritten in the HeavyIon track pass config with icf.minPT = 0.5 * Units.GeV.

Except this value was used to configure the minPT cut for the tracks used for photon conversion reconstruction flags.addFlag("TrkSel.minPt", lambda pcf: pcf.Tracking.MainPass.minPT). So in the HeavyIon config, an 0.4 GeV cut was used there, while the HeavyIon tracking config actually uses 0.5 GeV. In practice, I think it doesn't matter because the cut was looser.

I've updated the Egamma flag now to retrieve the minPT value of the configuration actually used for the main tracking pass

flags.addFlag("TrkSel.minPt", lambda pcf:
                  pcf.Tracking.__getattr__(
                      (pcf.Tracking.PrimaryPassConfig.value
                       if pcf.GeoModel.Run <= LHCPeriod.Run3
                       else pcf.Tracking.ITkPrimaryPassConfig.value)
                      +'Pass').minPT)

which yields the following difference in the HeavyIon config

Differences in components Settings in 1st file Settings in 2nd file
Component EMVertexBuilder.ConversionFinderTool.TrackSelector may differ
	minPt =  400.0  vs  500.0   <<

FYI @christos

A more relevant case is for the MinBias config were the tracking pT cut is lowered to 100 MeV

Component EMVertexBuilder.ConversionFinderTool.TrackSelector may differ
	minPt =  400.0  vs  100.0   <<

added 4 commits

• ff1428bc - Fix LowMu tracking config
• a3aefc29 - Fix for low mu config
• 28daf94d - Fix for cosmics
• 88b4f63e - Fix MinBias config

Compare with previous version

changed the description

added Run2-DataReco-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed Run4-MCReco-output-changed labels

marked this merge request as ready

This merge request affects 3 packages:

• InnerDetector/InDetConfig
• Reconstruction/egamma/egammaConfig
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@sroe ,@cgrefe ,@calfayan ,@tstreble as watchers

added Egamma InnerDetector Reconstruction review-pending-level-1 labels

CI Result FAILURE (hash 88b4f63e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9988] (remote access info)