Skip to content

Drop Tracking.cutLevel flag

Thomas Strebler requested to merge tstreble/athena:CutLevel_May21 into main

The Tracking.cutLevel flag was some flag inherited from the distant pass and very unlikely to be configured independently at this stage. Consequently it was just acting as a wrapper around a few other tracking flags, namely

def cutLevel(flags):
        if flags.Tracking.PrimaryPassConfig is PrimaryPassConfig.HeavyIon:
            return 4
        elif flags.Tracking.doLowMu:
            return 3
        elif flags.Beam.Type is BeamType.Cosmics:
            return 8
        elif flags.Tracking.doMinBias:
            return 12
        else:
            return 19

This flag is therefore removed in favour of an explicit configuration of the flags which depend on it.

Moreover ranges functions were built based on it in the TrackingPass flags but those were in most cases anyway overwritten in the actual configuration of the pass, so this was extremely confusing. Those ranges functions are removed as well.

Some changes are implemented for the minimum pT of the track used for photon conversions for non-default configs, so marking this as Reco output changing.

Relevant for ATLASRECTS-7947

FYI @ncalace

Edited by Thomas Strebler

Merge request reports