Revised the output ntuple branches, updated the test jobOption

Revised the output ntuple branches, and updated the test jobOption. This code will be used in the Muon calibration centre to produce the Muon Calibration Ntuples.

requested review from @jojungge, @emoyse, and @pscholer

closed

git rebase --onto upstream/24.0 upstream/main

reopened

marked this merge request as ready

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator

This merge request affects 4 files:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/CMakeLists.txt
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/MuonCalibSegmentCreator/MuonSegmentReader.h
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/python/MuonSegmentReaderConfig.py
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx

Adding @rosati ,@jojungge ,@apsallid ,@stavrop ,@kluit ,@pscholer as watchers

added 24.0 MuonSpectrometer review-pending-level-1 labels

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 5ff575a3)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10131] (remote access info)

Some comment on the indentation and the iterator. Others are good to me.

Mingxu (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 2 commits

• 28fd157f - rename inputdir
• 2707c7f9 - add trkHit_error, refined the indentent of if and for loop, abandon iterator in the for loop

Compare with previous version

resolved all threads

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator

This merge request affects 4 files:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/CMakeLists.txt
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/MuonCalibSegmentCreator/MuonSegmentReader.h
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/python/MuonSegmentReaderConfig.py
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx

Adding @apsallid ,@kluit ,@rosati ,@stavrop ,@pscholer ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 2707c7f9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10206] (remote access info)

added 1 commit

• 63b264d0 - simplify the prd for loop, remove the size check

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator

This merge request affects 4 files:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/CMakeLists.txt
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/MuonCalibSegmentCreator/MuonSegmentReader.h
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/python/MuonSegmentReaderConfig.py
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx

Adding @apsallid ,@stavrop ,@pscholer ,@jojungge ,@rosati ,@kluit as watchers

resolved all threads

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 63b264d0)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10222] (remote access info)

Let's not continue with indentation comments.

added 1 commit

• 2c085ab3 - improved the indentent again

Compare with previous version

resolved all threads

This merge request affects 1 package:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator

This merge request affects 4 files:

• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/CMakeLists.txt
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/MuonCalibSegmentCreator/MuonSegmentReader.h
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/python/MuonSegmentReaderConfig.py
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx

Adding @rosati ,@pscholer ,@apsallid ,@kluit ,@jojungge ,@stavrop as watchers

CI Result SUCCESS (hash 2c085ab3)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10261] (remote access info)

Code changes look fine from L1 perspective and the CI succeeded. Approving from L1 side.

removed review-pending-level-1 label

added review-approved label

added review-approved-tier0 label

mentioned in commit 783f6cca