Skip to content
Snippets Groups Projects

Resurrect CaloCellPos2Ntuple code + config

Merged Walter Lampl requested to merge wlampl/athena:CaloCellPosNtupCA into 24.0
All threads resolved!
  1. Fix CaloCellPos2Ntuple ntuple-duming algorithm for modern releases
  2. Create a CA-based config for it

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just one indentation issue, others look fine to me to approve. Mingxu (L1)

  • Walter Lampl added 1 commit

    added 1 commit

    • f9f59535 - reformat CaloCellPosition2Ntuple.h

    Compare with previous version

  • Walter Lampl resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Calorimeter/CaloCondPhysAlgs

    This merge request affects 4 files:

    • Calorimeter/CaloCondPhysAlgs/CMakeLists.txt
    • Calorimeter/CaloCondPhysAlgs/share/CaloCellPos2Ntuple.py
    • Calorimeter/CaloCondPhysAlgs/src/CaloCellPosition2Ntuple.cxx
    • Calorimeter/CaloCondPhysAlgs/src/CaloCellPosition2Ntuple.h

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash f9f59535)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10140] (remote access info)

  • Code changes look fine from L1 and the CI succeeded. Approving

    Qiyu, L1.

  • merged

  • Ahmed Tarek mentioned in commit 45833786

    mentioned in commit 45833786

  • Frank Winklmeier mentioned in merge request !71742 (merged)

    mentioned in merge request !71742 (merged)

  • Please register or sign in to reply
    Loading