Applying a cut for LRT before adding SP candidates to the data object

In the scope of my qualification task (JIRA: ATLIDTRKCP-538), I have applied an additional cut for LRTs in the production of 3 SP seeds before adding top and bottom SP candidates to the relevant data objects. The mentioned pT cut uses conformal mapping before the top-center and bottom-center space points are constructed. Although the main pT cut is applied in L.2480, in L.2395 the "coordinates" function requires a lot of CPU time. Applying a pT cut early on, in our case before the space point triplets are constructed, reduces the "coordinates" function's run time. With this additional cut, the CPU time ratio of the ITkSiSpTrackFinderLargeD0 to the ITkSiSpTrackFinder has decreased from 8.3 to 2.8, as tested using a ttbar sample. The efficiencies versus eta, pT, and prodR remain unchanged for the signal sample and the relevant plots can be found in the attachment.

assigned to @ncalace, @tstreble, @cvarni, and @delitez

lgtm

marked this merge request as ready

This merge request affects 2 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @sroe ,@gavrilen ,@goetz ,@tstreble as watchers

added ITk InnerDetector main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

132K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

added 1 commit

• df713015 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

resolved all threads

added 1 commit

• 5c8c07f9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @gavrilen ,@tstreble ,@sroe ,@goetz as watchers

WARNING: big files (>100K) are found in the changeset

132K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @sroe ,@gavrilen ,@goetz ,@tstreble as watchers

WARNING: big files (>100K) are found in the changeset

132K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

CI Result SUCCESS (hash 5a03eba3)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11024] (remote access info)

Hi @delitez,

please apply the suggestions from the open threads.

For future MRs, please create a topic branch to submit an MR instead of making the MR from your athena main branch (see instructions in our git tutorial). This way, the CI pipeline status should be correctly displayed (see discussion in ATLINFR-5406).

L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 0f256cbe - Update ITkSiSpacePointsSeedMaker.cxx according to the comments on const floats.

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @goetz ,@sroe ,@gavrilen ,@tstreble as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

132K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

resolved all threads

resolved all threads

CI Result SUCCESS (hash df713015)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11026] (remote access info)

CI Result SUCCESS (hash 5c8c07f9)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11027] (remote access info)

Looks good, approving (L1)

added review-approved label and removed review-pending-level-1 label

CI Result SUCCESS (hash 0f256cbe)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11036] (remote access info)

merged

mentioned in commit f48a2d26