simplify branch stopper implemented as a lambda

CkfBranchStopper can be simplified by converting it to call a lambda defined in findTracks.

added ACTS label

I see a 2% speedup in TrackFindingAlg for ttbar+PU200.

marked this merge request as ready

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @goetz ,@pagessin ,@adye ,@toyamaza ,@cvarni ,@jojungge ,@tbold as watchers

added Tracking main review-pending-level-1 labels

CI Result SUCCESS (hash 0a721f48)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10204] (remote access info)

added 1 commit

• 259cfe71 - simplify further: Acts::Delegate can in fact use a lambda capture

Compare with previous version

changed the description

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @cvarni ,@jojungge ,@tbold ,@toyamaza ,@goetz ,@adye ,@pagessin as watchers

added 1 commit

• cf319f05 - undo formatting change

Compare with previous version

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @jojungge ,@toyamaza ,@goetz ,@cvarni ,@tbold ,@adye ,@pagessin as watchers

CI Result SUCCESS (hash 259cfe71)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10225] (remote access info)

CI Result SUCCESS (hash cf319f05)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10226] (remote access info)

mentioned in merge request !71718 (merged)

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @jojungge ,@pagessin ,@adye ,@cvarni ,@tbold ,@goetz ,@toyamaza as watchers

CI Result SUCCESS (hash cf319f05)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10230] (remote access info)

Hi @adye there are some MR conflicts. Can you resolve them?

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build

added full-unit-tests label

Jenkins please retry a build

resolved all threads

marked this merge request as draft

added 130 commits

• cf319f05...54915b41 - 127 commits from branch atlas:main
• 46976e5d - CkfBranchStopper now calls a lambda
• 8e0463e0 - simplify further: Acts::Delegate can in fact use a lambda capture
• 2c6025ad - undo formatting change

Compare with previous version

marked this merge request as ready

changed the description

Jenkins please retry a build

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @pagessin ,@jojungge ,@adye ,@tbold ,@cvarni ,@toyamaza ,@goetz as watchers

CI Result FAILURE (hash 2c6025ad)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10264] (remote access info)

Let me tag @mmlynars for info that the changes are happening.

resolved all threads

Rerunning CI after !71744 (merged)

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/Acts/ActsTrackReconstruction

This merge request affects 3 files:

• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.cxx
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingAlg.h
• Tracking/Acts/ActsTrackReconstruction/src/TrackFindingData.h

Adding @jojungge ,@goetz ,@tbold ,@toyamaza ,@pagessin ,@adye ,@cvarni as watchers

removed full-unit-tests label

added review-pending-level-2 label and removed review-pending-level-1 label

lgtm. waiting for CI to confirm everything is ok and then I can approve

CI Result SUCCESS (hash 2c6025ad)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10316] (remote access info)

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 6d49a72b