Introduce a common naming scheme for methods and variables related to primary GenParticles

Primary GenParticles represent the initial truth particles passed to the simulation (i.e. those whose parent particles are not simulated). This merge request introduces a common naming scheme for methods of G4 UserInformation classes and ISF::TruthBinding and variables in client code relating to Primary GenParticles.

This makes it easier to see how the various UserInformation classes are kept in sync.

marked this merge request as draft

changed title from Draft: Sim doc part4 main to Draft: Rename variables and methods related to GenParticles representing particles prior to any interactions

This merge request affects 13 packages:

• Calorimeter/CaloG4Sim
• ForwardDetectors/ZDC/ZDC_SD
• LArCalorimeter/LArG4/LArG4Code
• LArCalorimeter/LArG4/LArG4H6SD
• Simulation/G4Sim/MCTruth
• Simulation/G4Utilities/G4DebuggingTools
• Simulation/G4Utilities/G4UserActions
• Simulation/G4Utilities/TrackWriteFastSim
• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
• TileCalorimeter/TileG4/TileGeoG4Calib

Affected files list will not be printed in this case

Adding @lmijovic ,@harkusha ,@pavol ,@solodkov ,@iouri ,@jchapman as watchers

added Calorimeter ForwardDetectors LAr Simulation Tile main review-pending-level-1 labels

changed title from Draft: Rename variables and methods related to GenParticles representing particles prior to any interactions to Draft: Introduce a common naming scheme for methods and variables related to primary GenParticles

changed the description

added 6 commits

• c9b6bb19 - Beginning the process of documenting simulation classes
• 2798120f - Flagging more instances of barcode-based logic
• e1ab6796 - AtlasG4EventUserInfo - rename methods used in CaloCalibrationHit creation
• 1ed3b709 - AtlasG4EventUserInfo: Drop obsolete methods
• 7e37da83 - Drop obsolete PrimaryParticleInformation::SetParticle(...) method
• 2693ee46 - Rename functions and variables relating to the Primary GenParticle, so that they match

Compare with previous version

changed the description

CI Result SUCCESS (hash 86b379cc)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10178] (remote access info)

removed review-pending-level-1 label

added 273 commits

• 2693ee46...72829691 - 272 commits from branch atlas:main
• da21b2f1 - Rename functions and variables relating to the Primary GenParticle, so that they match

Compare with previous version

marked this merge request as ready

This merge request affects 10 packages:

• ForwardDetectors/ZDC/ZDC_SD
• LArCalorimeter/LArG4/LArG4Code
• Simulation/G4Sim/MCTruth
• Simulation/G4Utilities/G4UserActions
• Simulation/G4Utilities/TrackWriteFastSim
• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
• TileCalorimeter/TileG4/TileGeoG4Calib

Affected files list will not be printed in this case

Adding @jchapman ,@lmijovic ,@iouri ,@harkusha ,@pavol ,@solodkov as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash da21b2f1)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10336] (remote access info)

Code changes look fine from L1 perspective and the CI succeeded. Approving from L1 side.

removed review-pending-level-1 label

added review-approved label

merged