Introduce a common naming scheme for methods and variables related to GenParticles representing particles prior to any interactions

The "Generation Zero" GenParticle is a GenParticle representing the intial state of the particle currently being simulated (i.e. prior to any interactions). Generation Zero GenParticles may be primary particles (initial truth particles passed to the simulation (i.e. those whose parent particles are not simulated)) or secondary particles (new particles created by interactions and decays during the simulation). This merge request introduces a common naming scheme for methods of G4 UserInformation classes and ISF::TruthBinding and variables in client code relating to Generation Zero GenParticles.

This makes it easier to see how the various UserInformation classes are kept in sync.

changed the description

added 7 commits

• c9b6bb19 - Beginning the process of documenting simulation classes
• 2798120f - Flagging more instances of barcode-based logic
• e1ab6796 - AtlasG4EventUserInfo - rename methods used in CaloCalibrationHit creation
• 1ed3b709 - AtlasG4EventUserInfo: Drop obsolete methods
• 7e37da83 - Drop obsolete PrimaryParticleInformation::SetParticle(...) method
• 2693ee46 - Rename functions and variables relating to the Primary GenParticle, so that they match
• 20a1747d - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

added 274 commits

• 20a1747d...72829691 - 272 commits from branch atlas:main
• da21b2f1 - Rename functions and variables relating to the Primary GenParticle, so that they match
• d087d252 - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

added 30 commits

• d087d252...e9f780f5 - 28 commits from branch atlas:main
• eda77d8c - Rename functions and variables relating to the Primary GenParticle, so that they match
• 28074bf3 - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

added 11 commits

• 28074bf3...036a7903 - 10 commits from branch atlas:main
• 14d3ec46 - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

marked this merge request as ready

This merge request affects 4 packages:

• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools

Affected files list will not be printed in this case

Adding @lmijovic ,@jchapman as watchers

added Simulation main review-pending-level-1 labels

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 14d3ec46)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10379] (remote access info)

marked this merge request as draft

added 1 commit

• 923f5a8e - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

marked this merge request as ready

This merge request affects 4 packages:

• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools

Affected files list will not be printed in this case

Adding @jchapman ,@lmijovic as watchers

CI Result FAILURE (hash 923f5a8e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10384] (remote access info)

marked this merge request as draft

removed review-pending-level-1 label

added 1 commit

• b7ed0c15 - Rename variables and methods related to GenParticles representing particles...

Compare with previous version

marked this merge request as ready

This merge request affects 4 packages:

• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event
• Simulation/ISF/ISF_Geant4/ISF_Geant4Tools

Affected files list will not be printed in this case

Adding @lmijovic ,@jchapman as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash b7ed0c15)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10390] (remote access info)

Looks good, approving - L2

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c3dd109c