Acts Track Finding ptMin and absEtaMax cuts in branch stopper

• if ptMinMeasurements is specified for the given seed collection, applies ptMin cut in branch stopper once ptMinMinMeasurements have been encountered.
• if absEtaMaxMeasurements is specified for the given seed collection, applies absEtaMax cut in branch stopper once absEtaMaxMeasurements have been encountered.

added ACTS label

marked this merge request as draft

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @toyamaza ,@cvarni ,@goetz ,@pagessin ,@tbold ,@jojungge ,@adye as watchers

added Tracking main review-pending-level-1 labels

CI Result FAILURE (hash 449fe11f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10227] (remote access info)

removed review-pending-level-1 label

Jenkins please retry a build

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @adye ,@cvarni ,@pagessin ,@toyamaza ,@tbold ,@goetz ,@jojungge as watchers

CI Result FAILURE (hash 449fe11f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10229] (remote access info)

@adye the failure is related to the ActsCheckObjectCounts test. Can you update the reference?

Jenkins please retry a build

mentioned in merge request !71697 (merged)

added 1 commit

• ac4cff92 - update refs

Compare with previous version

resolved all threads

@adye I'm afraid this MR got merge conflicts. Can you resolve them?

I see a 41% speedup with ttbar+PU200 this MR, and even a slight improvement in efficiency and resolutions!

(caveat: I'm not sure whether !71683 (merged) was included in my reference for this comparison, so it might not be quite that much. I'll do a proper test once I can rebase on top of !71697 (merged).)

following up from @tbold's comment on !71697, I should probably rename doBranchHoleCut to doBranchStopper.

added 1 commit

• 36a4e74b - rename property doBranchHoleCut -> doBranchStopper

Compare with previous version

added 252 commits

• 36a4e74b...ca03a263 - 246 commits from branch atlas:main
• 2ec24894 - CkfBranchStopper now calls a lambda
• 7cc41d74 - undo formatting change
• dd60e50c - ptMin and absEtaMax cuts in branch stopper
• 70c7199a - fix property description
• 468a6309 - update refs
• e3fa7711 - rename property doBranchHoleCut -> doBranchStopper

Compare with previous version

resolved all threads

marked this merge request as ready

changed the description

Jenkins please retry a build

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @pagessin ,@goetz ,@toyamaza ,@jojungge ,@adye ,@cvarni ,@tbold as watchers

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

added review-pending-level-1 label

CI Result SUCCESS (hash e3fa7711)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10340] (remote access info)

Code changes look fine from L1 perspective and the CI succeeded. Approving from L1 side.

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit e9f780f5