Skip to content
Snippets Groups Projects

ActsEventCnv: make it possible to run without TrackingGeometryTool for Muon tests

Merged Edward Moyse requested to merge emoyse/athena:main-update-actstrkcnv into main
All threads resolved!

As per the description, this is necessary for !71240 (merged) but since it's independent, let's make it its own MR.

Should not impact any other tests, nor is it running in any production setting.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni
  • Carlo Varni
  • Jenkins please retry a build

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • :white_check_mark: CI Result SUCCESS (hash 73c93233)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10237] (remote access info)

  • Edward Moyse resolved all threads

    resolved all threads

  • Edward Moyse added 1 commit

    added 1 commit

    • f25921db - Check that GeomeotryContext is in SG (it should be!)

    Compare with previous version

  • This merge request affects 2 packages:

    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsEventCnv

    Affected files list will not be printed in this case

    Adding @toyamaza ,@jojungge ,@tbold ,@cvarni ,@pagessin as watchers

  • :white_check_mark: CI Result SUCCESS (hash f25921db)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10273] (remote access info)

  • Compilation warning in EvgenProdTools is unrelated.

  • Code changes look fine from L1 perspective and the CI succeeded. Approving from L1 side.

  • mentioned in commit 3d764cb7

  • Please register or sign in to reply
    Loading