main-coverity-ZdcAnalysis

Solve coverity defects in ZDCPulseAnalyzer:

• unintialised member variable
• COPY_INSTEAD_OF_MOVE
• Possible access of array out of bounds

This merge request affects 1 package:

• ForwardDetectors/ZDC/ZdcAnalysis

This merge request affects 2 files:

• ForwardDetectors/ZDC/ZdcAnalysis/Root/ZDCPulseAnalyzer.cxx
• ForwardDetectors/ZDC/ZdcAnalysis/ZdcAnalysis/ZDCPulseAnalyzer.h

added ForwardDetectors analysis-review-required main review-pending-level-1 labels

removed analysis-review-required label

added analysis-review-approved label

Approving from analysis release side. Tong (AR)

CI Result SUCCESS (hash 31b20530)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10537] (remote access info)

Approved from L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4c04b349