SCT_CalibAlgs: Update efficiency values written out to XML files
The efficiency for modules with no entries in the corresponding DQ histogram (due to e.g. disabled links, so no hits expected) is written out to XML files as 0
. With this change, the efficiency will be written out as -1
instead to help disentangle genuine issues with modules leading to 0 efficiency.
Note: The change does not affect downstream reconstruction or SCT calibration/conditions, as the XML files are only used by internal SCT tools to monitor the performance of modules.
Tagging @csander
Merge request reports
Activity
added 122 commits
-
125090b1...e7157c6f - 121 commits from branch
atlas:24.0
- b2ffe5af - write out efficiency as -1 to XML file if it is 0 due to no entries (e.g. for disabled links)
-
125090b1...e7157c6f - 121 commits from branch
added 24.0 InnerDetector review-pending-level-1 labels
CI Result SUCCESS (hash 125090b1) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11922] (remote access info) CI Result SUCCESS (hash b2ffe5af) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11923] (remote access info) Compilation warning is unrelated, seems to be introduced by !72445 (merged)
Tagging review-pending-level-2 for advise here since the warning in compilation seems to be unrelated. Joany (L1)
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/24.0/Trigger/TriggerCommon/TriggerMenuMT/python/TriggerAPI/TriggerAPISession.py:359:9: warning: ATL901: use 'AthenaCommon.Logging' instead of 'print' print(df.sort_values(by=['triggerType','livefraction','name'],ascending=[True,False,True]).to_string(index=False))
removed review-pending-level-1 label
added review-pending-level-2 label
removed review-pending-level-2 label
added review-approved label
added review-approved-tier0 label
mentioned in commit f126f22c
mentioned in merge request !72584 (merged)