Skip to content

ElectronAnalysisConfig: Update electron ID to match recommendation

Filip Nechansky requested to merge ATLAS-EGamma/athena:main-update_el_id_blocks into main

Major changes:

  • suggesting renaming likelihoodWP to identificationWP as that is more precise now that we have DNN. Updated references within athena, can add legacy likelihoodWP option temporarily which prints warning (or maybe better raises an error?) so outside frameworks can adapt.
  • Adds some basic protection to EfficiencyCorrectionTool against using correlation model which does not have valid inputs. When stat/uncorr histograms are not available the uncorr value defaults to -999.
  • Disabling ECIDS for run 3 as it is not intended to be used. Warning is printed and name of the setting is changed so it reflects that it is only used for run 2.

Minor:

  • Added options to define correlation method for various eff SFs and defaulting to SIMPLIFIED as that is ey recommendation. For run 3 where only total is supported for some efficiency corrs, added overwriting to TOTAL with warning.
  • Added DNN ID from decoration as those are now available.
  • Not allowing to run chargeID for DNN as charge flip rejection is handled within DNN.

Tagging @mojeda @honguyen @ludovica @kristin

Edited by Filip Nechansky

Merge request reports