Skip to content

main-cleanup-DerivationFrameworkSUSY

Shaun Roe requested to merge sroe/athena:main-cleanup-DerivationFrameworkSUSY into main

reduce complexity of SUSYSignaltagger::finalStateID by extracting free functions and introducing an array of criteria to categorise the process. Introduced unit tests as regression tests against the original code.

Before this MR:

NLOC CCN token PARAM length location

183 222 2094 2 227 DerivationFramework::SUSYSignalTagger::finalStateID@168-394@./PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/src/SUSYSignalTagger.cxx

after this MR:

NLOC CCN token PARAM length location

50 12 407 2 56 DerivationFramework::finalStateID@135-190@./PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/src/utilityFunctions.cxx

Complexity moved to some other functions, of course:

NLOC CCN token PARAM length location

28 57 577 1 34 DerivationFramework::gluinoSquarkClassification@22-55@./PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/src/utilityFunctions.cxx 34 57 595 1 45 DerivationFramework::gauginoPairProduction@58-102@./PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/src/utilityFunctions.cxx 62 42 619 3 66 DerivationFramework::SUSYSignalTagger::FindSusyHardProc@76-141@./PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/src/SUSYSignalTagger.cxx

Edited by Shaun Roe

Merge request reports