Adding Delayed Jets HLT Chains from ATR-29738
All tests passing except a discrepancy in counts compared to reference due to the newly added chain HLT_2j45_2j55_3timeSig15_L14jJ40
which wasn't in either of the menus. If CI doesn't resolve this automatically, will try with a patch.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TriggerCommon/TriggerMenuMT
This merge request affects 2 files:
- Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Dev_pp_run3_v1.py
- Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py
Adding @iriu ,@sutt ,@carquin ,@ggonella ,@ademaria ,@shanisch ,@lidiaz ,@gipezzul ,@slai as watchers
added 24.0 Trigger TriggerMenu review-pending-level-1 labels
CI Result FAILURE (hash 39a640b8)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13222] (remote access info)added 1 commit
- 3df6c35c - Applying the patch to the reference counts for the new delayed jets trigger, as suggested by the CI
This merge request affects 3 packages:
- Trigger/TrigValidation/TrigAnalysisTest
- Trigger/TrigValidation/TrigP1Test
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @ademaria ,@salderwe ,@carquin ,@iriu ,@gipezzul ,@martindl ,@shanisch ,@lidiaz ,@vmartin ,@okumura ,@sutt ,@slai ,@ggonella as watchers
added changes-trigger-counts label
WARNING: big files (>100K) are found in the changeset 388K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py 544K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref 124K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Dev_pp_run3_v1.py 368K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref CI Result SUCCESS (hash 3df6c35c)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13236] (remote access info)- Resolved by Lidija Zivkovic
Hi @dmankad, is it intended that
HLT_2j45_2j55_3timeSig15_L14jJ40
goes directly into the Physics menu and not Dev? Other wise this looks good.Cheers, Philipp (L1)
added review-user-action-required label and removed review-pending-level-1 label
added review-approved label and removed review-user-action-required label
Hi @lidiaz, sorry we missed the deadline. I thought the comment was specific to that one question. I wanted to be sure before merging. Now it looks good, I can merge ready for tomorrow.
Thanks, Tim.
added review-approved-point1 label
mentioned in commit e3b6e3e0
mentioned in merge request !73161 (merged)
mentioned in merge request !73161 (merged)
mentioned in commit 4d412c71