Add option for storing L1 jet RoIs to PHYS derivations

This adds an option (disabled by default) to store L1 jet RoIs to PHYS derivation formats. These are required for trigger matching by analyses working on the turn-on region of jet triggers.

The size has been found to be, on average, 0.077 kb/evt in data and 0.15 kb/evt in a resonant HHH->6b signal MC sample. I estimate this can be reduced by a factor of about 3 if necessary by storing only the eta, phi, and et, if this is technically possible.

Since AMG is unavailable for a few weeks to discuss including this more widely, the new flag is disabled by default but can be manually turned on (e.g. in a preExec) for specific cases where users need it for testing etc. in the meantime.

Only "legacy" L1 jet RoIs (i.e. not Phase-I) are included here. No checks on the data year/MC campaign are needed for now, since this is enabled manually case-by-case. The Phase-I RoIs can be considered in a separate MR.

changed the description

If we do this, then to me it makes sense to add phase-I at the same time as legacy is no longer in production use at P1 for single or multijets. Would need to add 'xAOD::jFexSRJetRoIContainer#L1_jFexSRJetRoI' and associated aux.

It could potentially be restricted to >= mc23e, >= data24

I agree with Tim that we also need a solution for Phase-I. I'd say that whether we include it in this MR should depend on whether the larger disk size (0.398 kb/event for data according to @tamartin) means AMG is/isn't happy to add it to PHYS(LITE) content as is. If that's too big, then I'd suggest we handle that in a separate MR, perhaps with some form of slimming/thinning.

On a related point, should we disable these "legacy" RoIs for samples >=mc23e and >=data24?

Tagging @gwatts & @ekourlit (AMG conveners) for their opinions.

I think it makes sense to restrict to legacy in mc23a/d + data22/23 (earlier if needed), and Phase 1 in mc23e + data24 and later.

I'm surprised by the large quote for the jFEX jet RoIs, though. I looked in a couple of arbitrary data24 files, and got 0.054 kB for the basic RoIs, 0.022 kB for the extended RoI info. Is the quote of 0.38 kB for all of the Phase-1 L1 content?

added 882 commits

• 1cc530c9...97f27014 - 880 commits from branch atlas:main
• 02f42d6f - Add flag condition to store L1 jet RoIs to PHYS
• 9437e3e4 - Pull commits from main

Compare with previous version

marked this merge request as ready

changed title from Draft: Add L1 jet RoIs to PHYS derivations to Add option for storing L1 jet RoIs to PHYS derivations

changed the description

This merge request affects 2 packages:

• Control/AthenaConfiguration
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

Affected files list will not be printed in this case

Adding @gemmeren ,@maszyman ,@zmarshal ,@ssnyder ,@fwinkl ,@dshope ,@emmat ,@jcatmore as watchers

added Core Derivation Trigger analysis-review-required full-unit-tests main review-pending-level-1 labels

added 1 commit

• 2ac921a2 - Include file defining new flag

Compare with previous version

resolved all threads

This merge request affects 3 packages:

• Control/AthenaConfiguration
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTrigger

Affected files list will not be printed in this case

Adding @emmat ,@zmarshal ,@dshope ,@fwinkl ,@ssnyder ,@maszyman ,@jcatmore ,@gemmeren as watchers

CI Result FAILURE (hash 9437e3e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14508] (remote access info)

CI Result SUCCESS (hash 2ac921a2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14510] (remote access info)

Unrelated warning fixed with !73721 (merged)

Looks good to me, approving.

Cheers, Philipp (L1)

added review-approved label and removed review-pending-level-1 label